Skip to content

Commit ef3ffb3

Browse files
authored
Merge pull request #297 from JoseEspinosa/updates
Address review comments
2 parents a05e1aa + 4760fc7 commit ef3ffb3

File tree

7 files changed

+29
-41
lines changed

7 files changed

+29
-41
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@ work/
33
data/
44
results/
55
.DS_Store
6+
testing/
67
testing*
78
*.pyc

CITATIONS.md

+4-11
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@
2626

2727
> Langmead, B. and Salzberg, S. L. 2012 Fast gapped-read alignment with Bowtie 2. Nature methods, 9(4), p. 357–359. doi: 10.1038/nmeth.1923.
2828
29+
- [Chromap](https://doi.org/10.1038/s41467-021-26865-w)
30+
31+
> Zhang H, Song L, Wang X, Cheng H, Wang C, Meyer CA, Liu T, Tang M, Aluru S, Yue F, Liu XS and Li H. Fast alignment and preprocessing of chromatin profiles with Chromap. Nature communications. 2021, 12(1), 1-6. doi: 10.1038/s41467-021-26865-w
32+
2933
- [deepTools](https://www.ncbi.nlm.nih.gov/pubmed/27079975/)
3034

3135
> Ramírez F, Ryan DP, Grüning B, Bhardwaj V, Kilpert F, Richter AS, Heyne S, Dündar F, Manke T. deepTools2: a next generation web server for deep-sequencing data analysis. Nucleic Acids Res. 2016 Jul 8;44(W1):W160-5. doi: 10.1093/nar/gkw257. Epub 2016 Apr 13. PubMed PMID: 27079975; PubMed Central PMCID: PMC4987876.
@@ -83,10 +87,6 @@
8387

8488
> Love MI, Huber W, Anders S. Moderated estimation of fold change and dispersion for RNA-seq data with DESeq2. Genome Biol. 2014;15(12):550. PubMed PMID: 25516281; PubMed Central PMCID: PMC4302049.
8589
86-
- [vsn](https://bioconductor.org/packages/release/bioc/html/vsn.html)
87-
88-
> Wolfgang Huber, Anja von Heydebreck, Holger Sueltmann, Annemarie Poustka and Martin Vingron. Variance Stabilization Applied to Microarray Data Calibration and to the Quantification of Differential Expression. Bioinformatics 18, S96-S104 (2002).
89-
9090
- [UpSetR](https://CRAN.R-project.org/package=UpSetR)
9191

9292
> Nils Gehlenborg (2017). UpSetR: A More Scalable Alternative to Venn and Euler Diagrams for Visualizing Intersecting Sets.
@@ -107,10 +107,6 @@
107107

108108
> Raivo Kolde (2018). pheatmap: Pretty Heatmaps.
109109
110-
- [lattice](https://cran.r-project.org/web/packages/lattice/index.html)
111-
112-
> Sarkar, Deepayan (2008) Lattice: Multivariate Data Visualization with R. Springer, New York. ISBN 978-0-387-75968-5.
113-
114110
- [RColorBrewer](https://CRAN.R-project.org/package=RColorBrewer)
115111

116112
> Erich Neuwirth (2014). RColorBrewer: ColorBrewer Palettes.
@@ -119,9 +115,6 @@
119115

120116
> Trevor L Davis (2018). optparse: Command Line Option Parser.
121117
122-
- [xfun](https://CRAN.R-project.org/package=xfun)
123-
> Yihui Xie (2018). xfun: Miscellaneous Functions by 'Yihui Xie'.
124-
125118
## Software packaging/containerisation tools
126119

127120
- [Anaconda](https://anaconda.com)

assets/samplesheet.csv

-3
This file was deleted.

conf/modules.config

+1-1
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ if (!params.skip_plot_fingerprint) {
510510
ext.args = { [
511511
'--skipZeros',
512512
"--numberOfSamples $params.fingerprint_bins",
513-
"--labels $meta.ip $meta.control"
513+
"--labels $meta.id $meta.control"
514514
].join(' ').trim() }
515515
ext.prefix = { "${meta.id}.mLb.clN" }
516516
publishDir = [

modules/local/multiqc.nf

+3
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ process MULTIQC {
4444

4545
path ('featurecounts/*')
4646

47+
path ('deseq2/*')
48+
path ('deseq2/*')
49+
4750
output:
4851
path "*multiqc_report.html", emit: report
4952
path "*_data" , emit: data

nextflow_schema.json

+11-22
Original file line numberDiff line numberDiff line change
@@ -323,25 +323,6 @@
323323
}
324324
}
325325
},
326-
"deseq_qc_options": {
327-
"title": "Differential analysis options",
328-
"type": "object",
329-
"fa_icon": "fas fa-not-equal",
330-
"description": "Options to adjust differential analysis criteria.",
331-
"properties": {
332-
"deseq2_vst": {
333-
"type": "boolean",
334-
"description": "Use vst transformation instead of rlog with DESeq2.",
335-
"help_text": "See [DESeq2 docs](http://bioconductor.org/packages/devel/bioc/vignettes/DESeq2/inst/doc/DESeq2.html#data-transformations-and-visualization).",
336-
"fa_icon": "fas fa-dolly"
337-
},
338-
"skip_deseq2_qc": {
339-
"type": "boolean",
340-
"fa_icon": "fas fa-fast-forward",
341-
"description": "Skip DESeq2 PCA and heatmap plotting."
342-
}
343-
}
344-
},
345326
"process_skipping_options": {
346327
"title": "Process skipping options",
347328
"type": "object",
@@ -363,6 +344,12 @@
363344
"description": "Skip Preseq.",
364345
"fa_icon": "fas fa-fast-forward"
365346
},
347+
"deseq2_vst": {
348+
"type": "boolean",
349+
"description": "Use vst transformation instead of rlog with DESeq2.",
350+
"help_text": "See [DESeq2 docs](http://bioconductor.org/packages/devel/bioc/vignettes/DESeq2/inst/doc/DESeq2.html#data-transformations-and-visualization).",
351+
"fa_icon": "fas fa-dolly"
352+
},
366353
"skip_plot_profile": {
367354
"type": "boolean",
368355
"description": "Skip deepTools plotProfile.",
@@ -378,6 +365,11 @@
378365
"description": "Skip Phantompeakqualtools.",
379366
"fa_icon": "fas fa-fast-forward"
380367
},
368+
"skip_deseq2_qc": {
369+
"type": "boolean",
370+
"fa_icon": "fas fa-fast-forward",
371+
"description": "Skip DESeq2 PCA and heatmap plotting."
372+
},
381373
"skip_igv": {
382374
"type": "boolean",
383375
"description": "Skip IGV.",
@@ -587,9 +579,6 @@
587579
{
588580
"$ref": "#/definitions/peak_calling_options"
589581
},
590-
{
591-
"$ref": "#/definitions/deseq_qc_options"
592-
},
593582
{
594583
"$ref": "#/definitions/process_skipping_options"
595584
},

workflows/chipseq.nf

+9-4
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,9 @@ workflow CHIPSEQ {
506506
//
507507
// Consensus peaks analysis
508508
//
509-
ch_macs2_consensus_bed_lib = Channel.empty()
509+
ch_macs2_consensus_bed_lib = Channel.empty()
510+
ch_deseq2_pca_multiqc = Channel.empty()
511+
ch_deseq2_clustering_multiqc = Channel.empty()
510512
if (!params.skip_consensus_peaks) {
511513
// Create channel: [ meta , [ peaks ] ]
512514
// Where meta = [ id:antibody, multiple_groups:true/false, replicates_exist:true/false ]
@@ -582,6 +584,8 @@ workflow CHIPSEQ {
582584
ch_deseq2_pca_header,
583585
ch_deseq2_clustering_header
584586
)
587+
ch_deseq2_pca_multiqc = DESEQ2_QC.out.pca_multiqc
588+
ch_deseq2_clustering_multiqc = DESEQ2_QC.out.dists_multiqc
585589
}
586590
}
587591

@@ -654,9 +658,10 @@ workflow CHIPSEQ {
654658

655659
ch_custompeaks_frip_multiqc.collect{it[1]}.ifEmpty([]),
656660
ch_custompeaks_count_multiqc.collect{it[1]}.ifEmpty([]),
657-
ch_plothomerannotatepeaks_multiqc.collect{it[1]}.ifEmpty([]),
658-
ch_subreadfeaturecounts_multiqc.collect{it[1]}.ifEmpty([])//,
659-
// path ('macs/consensus/*') from ch_macs_consensus_deseq_mqc.collect().ifEmpty([])
661+
ch_plothomerannotatepeaks_multiqc.collect().ifEmpty([]),
662+
ch_subreadfeaturecounts_multiqc.collect{it[1]}.ifEmpty([]),
663+
ch_deseq2_pca_multiqc.collect().ifEmpty([]),
664+
ch_deseq2_clustering_multiqc.collect().ifEmpty([])
660665
)
661666
multiqc_report = MULTIQC.out.report.toList()
662667
}

0 commit comments

Comments
 (0)