Skip to content

Commit a650203

Browse files
authored
Merge branch 'dev' into fix-multiqc-shared-mem-error
2 parents f93bffc + 5908238 commit a650203

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
### Enhancements & fixes
99

10+
- [[#428](https://github.com/nf-core/chipseq/issues/428)] - Bump MultiQC version to 1.25.1
1011
- [[PR #434](https://github.com/nf-core/chipseq/pull/434)] - Prevent pipeline fails from erroneous param validation when igenomes is used.
1112
- [[#432](https://github.com/nf-core/chipseq/issues/432)] - Fix `GFFREAD` call to have the two expected input channels.
12-
- [[#428](https://github.com/nf-core/chipseq/issues/428)] - Bump MultiQC version to 1.25.1
13+
- [[PR #444](https://github.com/nf-core/chipseq/pull/444)] - Add empty map to ch_gff so that when provided by the user `GFFREAD` works.
1314

1415
### Parameters
1516

subworkflows/local/prepare_genome.nf

+2-2
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ workflow PREPARE_GENOME {
7171
} else if (gff) {
7272
if (gff.endsWith('.gz')) {
7373
ch_gff = GUNZIP_GFF([[:], file(gff, checkIfExists: true)]).gunzip.map { it[1] }
74-
ch_versions = ch_versions.mix(GUNZIP_GFF.out.versions).map { [ [:], it ] }
74+
ch_versions = ch_versions.mix(GUNZIP_GFF.out.versions)
7575
} else {
76-
ch_gff = Channel.value(file(gff, checkIfExists: true))
76+
ch_gff = Channel.value(file(gff, checkIfExists: true)).map { [ [:], it ] }
7777
}
7878

7979
ch_gtf = GFFREAD(ch_gff, []).gtf.map { it[1] }

workflows/chipseq.nf

+4-1
Original file line numberDiff line numberDiff line change
@@ -524,6 +524,8 @@ workflow CHIPSEQ {
524524
//
525525
// MODULE: MultiQC
526526
//
527+
ch_multiqc_report = Channel.empty()
528+
527529
if (!params.skip_multiqc) {
528530
ch_multiqc_config = Channel.fromPath("$projectDir/assets/multiqc_config.yml", checkIfExists: true)
529531
ch_multiqc_custom_config = params.multiqc_config ? Channel.fromPath( params.multiqc_config ): Channel.empty()
@@ -578,7 +580,8 @@ workflow CHIPSEQ {
578580
ch_multiqc_report = MULTIQC.out.report
579581
}
580582

581-
emit:multiqc_report = MULTIQC.out.report.toList() // channel: /path/to/multiqc_report.html
583+
emit:
584+
multiqc_report = ch_multiqc_report.toList() // channel: /path/to/multiqc_report.html
582585
versions = ch_versions // channel: [ path(versions.yml) ]
583586

584587
}

0 commit comments

Comments
 (0)