Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version 2.4.0 #180

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Bump version 2.4.0 #180

merged 3 commits into from
Nov 5, 2024

Conversation

Daniel-VM
Copy link
Contributor

@Daniel-VM Daniel-VM commented Oct 25, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

This PR prepares dev for releasing version 2.4.0.

Daniel-VM added a commit to Daniel-VM/bacass that referenced this pull request Oct 25, 2024
@Daniel-VM
update changelog nf-core#180
994e9d9
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 9c95fb7

+| ✅ 208 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-05 11:06:46

@sralchemab
Copy link

Hi @Daniel-VM. When do you think you'll be releasing v2.4.0? Don't want to push, just need to know whether I wait a bit more for the next official release or work from a specific commit. Thanks in advance!

@Daniel-VM
Copy link
Contributor Author

Hi @sralchemab,

Apologies for the delay in the version release. There's just one PR remaining before we release version 2.4.0. It should be ready by the end of this week.

@Daniel-VM Daniel-VM marked this pull request as ready for review November 5, 2024 08:24
d4straub
d4straub approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Daniel-VM
Copy link
Contributor Author

Thanks 🙏🏾

@Daniel-VM Daniel-VM merged commit 067fb0f into nf-core:dev Nov 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel-VM @sralchemab @d4straub