Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version 2.2.0dev #100

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Bump version 2.2.0dev #100

merged 3 commits into from
Oct 24, 2023

Conversation

Daniel-VM
Copy link
Contributor

Bump version 2.2.0dev

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 8a24a5a

+| ✅ 159 tests passed       |+
#| ❔   1 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-24 08:50:18

d4straub
d4straub approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I dont really understand why nf-core branch protection / test (pull_request_target) fails.

@Daniel-VM
Copy link
Contributor Author

I just found a thread on slack that talks about this. It happens when you close a PR against the master branch, and create a new PR instead of editing the closed PR.
(my fault, I didn't take the time to wait for the message to appear).

@Daniel-VM Daniel-VM merged commit 77cab10 into nf-core:dev Oct 24, 2023
@Daniel-VM Daniel-VM deleted the bump-version-2.2.0dev branch October 24, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daniel-VM @d4straub