Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: list addr:housenumber also when they are not a building attribute #19

Open
marcobra opened this issue Mar 31, 2016 · 2 comments

Comments

@marcobra
Copy link

Hi,

the housenumbers are not listed when are simple points on osm map.

Adding this code made addr:housenumber code listed...

please add this "elif" code into osminforesults.py, below line 133 :

                elif 'addr:housenumber' in elementTags.keys():
                    if 'addr:street' in elementTags.keys() and 'addr:housenumber' in elementTags.keys():
                        elementTitle = elementTags['addr:street'] + ', ' + elementTags['addr:housenumber']

In attach the modified file...

osminforesults.py.zip

and the testing result
screenshot from 2016-03-31 12 57 40

Thank

@marcobra marcobra changed the title feature request: list addr:housenumber also when are not tied to building element feature request: list addr:housenumber also when they are not a building attribute Mar 31, 2016
@simgislab
Copy link
Member

@marcobra
Copy link
Author

marcobra commented Apr 1, 2016

ok it is the same file but not similar:

this "elif" is at same level of

'if 'building' in elementTags.keys():'

and show points elements with addresses also when the "building" tag is not present...

if 'building' in elementTags.keys():
...
...
elif 'addr:housenumber' in elementTags.keys():

and differ from this, the addr:street here is showed only if there is a tag "building" in element

if 'building' in elementTags.keys():
if 'addr:street' in elementTags.keys() and 'addr:housenumber' in elementTags.keys():
elementTitle = elementTags['addr:street'] + ', ' + elementTags['addr:housenumber']
else:
elementTitle = 'building'

Thank
Marco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants