Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REUSE compliance #1573

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add REUSE compliance #1573

merged 4 commits into from
Oct 29, 2024

Conversation

AndyScherzinger
Copy link
Member

WIP

@AndyScherzinger AndyScherzinger force-pushed the docs/noid/reuse-compliance branch from fa736ec to 7a3d88d Compare October 23, 2024 17:15
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.50%. Comparing base (136bee9) to head (161911f).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1573   +/-   ##
=========================================
  Coverage     42.50%   42.50%           
  Complexity      102      102           
=========================================
  Files            19       19           
  Lines           327      327           
=========================================
  Hits            139      139           
  Misses          188      188
Flag Coverage Δ
unittests 42.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndyScherzinger AndyScherzinger force-pushed the docs/noid/reuse-compliance branch from aaf9396 to 3836370 Compare October 24, 2024 09:38
@AndyScherzinger
Copy link
Member Author

/compile /

@AndyScherzinger AndyScherzinger force-pushed the docs/noid/reuse-compliance branch from 3836370 to 1471c25 Compare October 24, 2024 09:39
st3iny
st3iny approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static analysis failure is not related and cs checks run locally. I'd be ok with force merging this PR and fixing CI later.

@st3iny
Copy link
Member

st3iny commented Oct 29, 2024

See #1495 and #1577 for CI fixes.

AndyScherzinger and others added 4 commits October 29, 2024 11:00
@AndyScherzinger @st3iny
docs(spdx): Add SPDX header
1a8782e 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger @st3iny
docs(readme): Add reuse status badge
94f6088 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger @st3iny
ci(reuse): Add reuse check
88ab4e5 
Signed-off-by: Andy Scherzinger <[email protected]>
@nextcloud-command @st3iny
chore(assets): Recompile assets
161911f 
Signed-off-by: nextcloud-command <[email protected]>
@st3iny st3iny force-pushed the docs/noid/reuse-compliance branch from 90b84a1 to 161911f Compare October 29, 2024 10:00
@st3iny st3iny enabled auto-merge October 29, 2024 10:00
@st3iny st3iny merged commit bc97fa7 into master Oct 29, 2024
26 checks passed
@st3iny st3iny deleted the docs/noid/reuse-compliance branch October 29, 2024 10:02
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

Assignees
No one assigned
Labels
4. to release technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyScherzinger @st3iny @nextcloud-command