Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increate length of shared secret to 160 chars as per RFC recommendation #1482

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Increate length of shared secret to 160 chars as per RFC recommendation #1482

merged 2 commits into from
Feb 6, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen self-assigned this Jan 24, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfcdd23) 44.29% compared to head (00a799c) 44.29%.
Report is 2 commits behind head on master.

❗ Current head 00a799c differs from pull request most recent head b4b530a. Consider uploading reports for the commit b4b530a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1482   +/-   ##
=========================================
  Coverage     44.29%   44.29%           
  Complexity       99       99           
=========================================
  Files            19       19           
  Lines           298      298           
=========================================
  Hits            132      132           
  Misses          166      166
Flag Coverage Δ
unittests 44.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickvergessen
Copy link
Member Author

Needs some UI adjustments though:

Bildschirmfoto vom 2024-01-24 11-51-47

Login screen is wrapping already:
Bildschirmfoto vom 2024-01-24 12-07-23

@st3iny
fix: wrap long TOTP secrets
b4b530a 
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
st3iny approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

I fixed the UI a bit to wrap long secrets.

@st3iny st3iny merged commit 143f694 into master Feb 6, 2024
16 checks passed
@st3iny st3iny deleted the bugfix/1324/increase-length-of-shared-secrets branch February 6, 2024 13:24
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@nickvergessen nickvergessen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token unsafe in FreeOTP
2 participants
@nickvergessen @st3iny