"Enable TOTP" checkbox gets ticked even if its not enabled successfully.

[theronakpatel]

Summary

Enable TOTP checkbox gets check marked even if we cancel enabling it. And hitting the ticked checkbox again results in endless loop. Reloading the page in any case shows the correct unchecked behavior.

The problem

• login to nextcloud
• Click Avatar on the top right and go to Settings >> Security
• Under Two Factor Authentication, Hit the enable TOTP checkbox
• Click cross on the Authentication required popup to cancel enabling the checkbox
• User receives Could not enable TOTP notification but the checkbox is shown as ticked
• Now Try unchecking the checkbox which will result it in endless loading.
• Now reload the page so it shows the box unchecked as desired.

What is the current behavior?

User receives Could not enable TOTP notification but the checkbox is shown as ticked, until the next reload of the page.

What is the expected correct behavior?

If Enabling TOTP fails the checkbox should remain unchecked. And ticked only when TOTP is successfully enabled.

Relevant screenshots

[theronakpatel]

Linked MR: #1314

[theronakpatel]

MR is merged, so closing this issue.

@chiotisn Can please prepare new release so that we can get this feature too.