PHP 8.1 compatibility

[jkhsjdhjs]

The app is compatible with PHP 8.1 and works fine without any warnings or errors. Only the max-version in info.xml needs to be adjusted.

[sempervictus]

This is preventing installation on Arch Linux systems, and the proposed fix seems to work fine.

[jkhsjdhjs]

@sempervictus If you're on Arch Linux you can install https://aur.archlinux.org/packages/nextcloud-app-totp. It patches the max-version automatically.

[dvzrv]

Nextcloud 24.0.0 has just been released and it supports PHP 8.1.
Will the max-version string be adapted, or are downstreams supposed to continue to patch it?

[Segaja]

Is there any update on this?

While the AUR is a great thing to have it would make sense that the plugin is compatible to the same PHP version as nextcloud itself. nextcloud 24 is now compatible up to php 8.1 and so should be this addon.

Since the issue says that the addon itself is compatible, what is holding this change back?

[ChristophWurst]

I'll try my best to work on this soon. If you have time for a contribution I'd appreciate a PR that adapts the app for PHP8.1, adjusts the CI matrices, lints, acceptance tests and gives it a good test overall.

On a very high level you can check out https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_24.html#php8-1 for migration help. From what I've seen in other apps any extended PHP interfaces have to be checked, e.g. JsonSerializable and string operations with possible null values.

Cheers

[sempervictus]

@ChristophWurst - #1216

[IzumiSenaSora]

An app like totp.... which is critical for every users to login securely in nextcloud .... when you guys release nextcloud you guys need to confirm that at least all critical apps like totp/webauth/e2e all up to date... before nextcloud major version release....

[sempervictus]

To @IzumiSenaSora's point about this being critical for functionality: any chance of the 2FA apps getting rolled into the main project to sync release cadence and functional testing?

[ChristophWurst]

PR is at #1227.

[AkechiShiro]

Could anyone report back on giving a try at updating their Nextcloud 23 to 24 with the following #1227 PR ?