Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: only add terms-of-service frontend script if the check is not passed yet #1047

Open
ShGKme opened this issue Feb 7, 2025 · 0 comments

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Feb 7, 2025

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Current process:

  1. App adds a frontend script
  2. Frontend makes an HTTP request to check for ToS being accepted

Proposal:

  1. Check for ToS on Backend
  2. Only add the frontend script if it is necessary

Result:

  • Removes an unnecessary script from the page which is actually needed only once per user
  • Removes HTTP request for a data that we could check in the first request
@ShGKme ShGKme changed the title Performance: only add terms-of-service if check is not passed yet Performance: only add terms-of-service frontend script if the check is not passed yet Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant