-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dark mode avatars when dark mode is used. #941
Comments
Currently the avatars are cached by the lib, need to make sure we invalidate the cache if the appearance changes |
or use 2 different cache keys. |
Yes, I’ll take a look. Might not be a problem afterall, because the url is the key 🧐 |
Since the urls are different there should not be an issue with the cache. |
I don't see a capability or a backport - so we check for NC 25 when doing this? |
Right! What would be the best way to proceed here @nickvergessen ? |
Yeah, it's a server thing and server people are not used to capabilities (yet). |
Yep, we store the server version already, so that should be pretty easy to do 👍 |
Android ref nextcloud/talk-android#2409
So when darkmode is on, you should load the avatar with /dark appended to the URL:
https://github.com/nextcloud/server/pull/33752/files#diff-4498c88983ae18872bd47b365d72a3604d1850596ea052d36da8bb7ad28f207eR48
The text was updated successfully, but these errors were encountered: