Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Add to Notes in Message Actions #3586

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Implementing Add to Notes in Message Actions #3586

merged 1 commit into from
Feb 1, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 22, 2024 •
edited
Loading

🖼️ Screenshots

  • Note to self option should only appear if conversation is available
  • Shows a pop up if message is sent successfully
  • Added ic_edit_note_24_xml
  • Implemented in MVVM for cleaner data flow
  • Added the option to the XML

ToDo

  • Allow files (+captions) to be shared to notes ( Gifs and contacts fall under this category )
  • Fails when the file isn't saved to cache. Likely problem with URI. Need to fix that. Test it out with camera.
  • Allow geo-location messages to be shared to notes
  • Allow Voice messages to be shared to notes

Poll messages don't have message actions attached anyway.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Jan 22, 2024
@rapterjet2004 rapterjet2004 force-pushed the issue-3584-note-to-self-action branch 2 times, most recently from c21c863 to 70b65e6 Compare January 26, 2024 19:15
@rapterjet2004 rapterjet2004 force-pushed the issue-3584-note-to-self-action branch from a489e49 to 43415a5 Compare January 31, 2024 14:29
@rapterjet2004 rapterjet2004 marked this pull request as ready for review January 31, 2024 14:33
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 31, 2024
@rapterjet2004 @mahibi
Impl "Add to Notes Action"
d45277b 
- Note to self option should only appear if conversation is available
- Added ic_edit_note_24_xml
- Implemented MVVM functions for cleaner data flow
- Added the option to the XML
- Works for Voice Messages
- Works for Files(and Gifs) + captions
- Works for GeoLocation Messages
- Added SnackBar

Signed-off-by: Julius Linus <[email protected]>
@mahibi mahibi enabled auto-merge February 1, 2024 11:18
@mahibi mahibi force-pushed the issue-3584-note-to-self-action branch from 43415a5 to d45277b Compare February 1, 2024 11:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Codacy

Lint

TypemasterPR
Warnings8080
Errors88

SpotBugs

CategoryBaseNew
Bad practice66
Correctness88
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total139139

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3586-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 8e40ff0 into master Feb 1, 2024
15 of 16 checks passed
@mahibi mahibi deleted the issue-3584-note-to-self-action branch February 1, 2024 12:23
@AndyScherzinger AndyScherzinger added this to the 18.1.0 milestone Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews feature: chat 🗨️ feedback-requested
Projects
None yet
Milestone
18.1.0
Development

Successfully merging this pull request may close these issues.

Add the "note to me" funktion to Android
3 participants
@rapterjet2004 @mahibi @AndyScherzinger