Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstracting away media player #4579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Abstracting away media player #4579

wants to merge 3 commits into from
+697 −473

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 7, 2025 •
edited
Loading

🖼️ Screenshots

Example of background play

🚧 TODO

  • Add functionality to MediaPlayerManager
  • Create Background Voice Message View
  • Rewrite ChatActivity to use MediaPlayerManager
    • play
    • stop
    • pause
    • seek
    • Bug: pausing and replaying causes the message to loop
    • Bug: On completion the message is not reset
  • Resumes playback of voice messages on screen rotation
  • Continue playing a voice message in background
    • Bug: Enter into the original conversation after lifecycle change. Seek Bar not updated.
    • Bug: After orientation change. Seek Bar not updated. Scope is canceled.
    • Add a reference to the conversation that the msg is in too. Maybe avatar or name
    • Bug: Occasionally, card shows up when played messaged is paused. Need to look into this
  • Implement Voice Message card
    • play
    • close
    • pause
    • avatar
    • animation
    • Bug: Pausing it destroys it
  • Auto play consecutive audio messages
    • prefetch audio messages
    • show fetched audio durations
    • temporarily mark as listened audio messages
    • Bug: Durations no longer count down, also they should match the playback speed
    • Bug: pausing resets the duration for some reason
  • Get playback speed controls working
    • bug: Works, but UI doesn't update ( check cycling too )
  • Bug: It crashes when playing the Voice Recording preview

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Jan 7, 2025
@rapterjet2004 rapterjet2004 self-assigned this Jan 7, 2025
@rapterjet2004 rapterjet2004 force-pushed the issue-4563-abstract-away-media-player branch from 76079a6 to 034600c Compare January 29, 2025 19:09
@rapterjet2004 rapterjet2004 marked this pull request as ready for review January 29, 2025 19:09
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 30, 2025
@mahibi mahibi added this to the 21.1.0 milestone Feb 5, 2025
@mahibi
Copy link
Collaborator

mahibi commented Feb 5, 2025

great 👍
won't be backported to 21.0

While it's of course an improvement to have the player inside the conversation list, i wonder if it's much more work to have it as a notification instead (Like Whatsapp and telegram have it..)?

@rapterjet2004
Copy link
Contributor Author

rapterjet2004 commented Feb 5, 2025 •
edited
Loading

great 👍
won't be backported to 21.0

While it's of course an improvement to have the player inside the conversation list, i wonder if it's much more work to have it as a notification instead (Like Whatsapp and telegram have it..)?

Could be done, but it would require adding a new dependency and a bit more boilerplate to work with notification. It should be in a separate PR

@rapterjet2004 rapterjet2004 force-pushed the issue-4563-abstract-away-media-player branch from 7140f96 to d6e6030 Compare February 7, 2025 16:24
@rapterjet2004 rapterjet2004 removed the request for review from sowjanyakch February 7, 2025 18:34
@rapterjet2004 rapterjet2004 force-pushed the issue-4563-abstract-away-media-player branch from 77d4731 to b9b3283 Compare February 18, 2025 13:31
@rapterjet2004
Abstracting away media player functionality to MediaPlayerManager
bc58e74 
- Most code removed from ChatActivity
- Most work in MediaPlayerManager
- Added BackgroundVoiceMessageCard

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004
linter
feac97f 
Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 force-pushed the issue-4563-abstract-away-media-player branch from 0a9b97d to feac97f Compare February 21, 2025 19:19
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4579-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104103
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222224
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310312

SpotBugs increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.1.0
Development

Successfully merging this pull request may close these issues.

Abstract away the MediaPlayer logic in ChatActivity to MediaPlayerManager
2 participants
@rapterjet2004 @mahibi