Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation creation modification #4250

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation creation modification #4250

wants to merge 4 commits into from

Conversation

sowjanyakch
Copy link
Collaborator

Resolves #4249

This PR implements:

  1. Hide Delete button in the new conversation screen and show it only when conversation avatar is set.
  2. Single line textfield for conversation name.
  3. Make conversation avatar sustain configuration changes.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch self-assigned this Sep 19, 2024
@sowjanyakch sowjanyakch force-pushed the conversation_creation_modification branch from 723dca8 to 72dabfb Compare September 19, 2024 13:03
@sowjanyakch
ktlint format
38e07e0 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch force-pushed the conversation_creation_modification branch from 93e643b to 38e07e0 Compare September 19, 2024 13:26
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8696
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4250-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch
Copy link
Collaborator Author

/backport to stable-20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

At least 1 approving review is required to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels
backport-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements for Conversation Creation Activity
1 participant
@sowjanyakch