Quoting on talk app android doesnt work well

[GretaD]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. Open Talk app on an android phone
2. Open an existing conversation and quote a message you already send and write something as reply
3. See the quote not showing up

Expected behaviour

I see the message i quoted

Actual behaviour

Quoting is empty

Talk app

Talk app version: (see apps administration page: /index.php/settings/apps)

Custom Signaling server configured: yes/no and version (see Talk administration settings: /index.php/settings/admin/talk#signaling_server)

Custom TURN server configured: yes/no (see Talk administration settings: /index.php/settings/admin/talk#turn_server)

Custom STUN server configured: yes/no (see Talk administration settings: /index.php/settings/admin/talk#stun_server)

Browser

Microphone available: yes/no

Camera available: yes/no

Operating system: Windows/Ubuntu/Mac/...

Browser name: Firefox/Chrome/Safari/...

Browser version: 124/125/...

Browser log

``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```

Server configuration

Operating system: Ubuntu/RedHat/...

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 8.1/8.2/8.3

Nextcloud Version: (see administration page)

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your server installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

Server log (data/nextcloud.log)

Insert your server log here

[GretaD]

I was chatting with @ChristophWurst, i would be curious if Christoph can see the quoting on his phone. Because all looks good on web.

[AndyScherzinger]

@rapterjet2004 I also experienced this today. The message showed up when I navigated back to the list of conversations and back into the same conversation. So there seems to be some rendering issue. On top it also had issues with rendering the content correctly (link has been too "long") however I can't share a screenshot of that conversation.

[rapterjet2004]

Not sure if this can be an easy fix, because since switching to offline first we don't keep the parent message directly in storage, but instead save it's id parentMessageId: Long? so it can be looked up in the database later. However, if the parent message itself it not saved ( for example If it's really old ) then the UI only shows an empty String. However, when you scroll up, the message is then saved to storage but this doesn't immediately refresh the adapter unless you reenter the conversation.

I think what I can do is add some progress indicators to make the UI more user friendly. I'll talk to @mahibi about it when he comes back.

Not sure about the long link though, I was unable to recreate that bug. I tested it with this and it seems to render fine. Although I do notice some flickering, probably has something to do with the refresh logic. Will have to fix that.

[SystemKeeper]

Not sure if this works for your offline implementation, but we update/store a parent message when we receive a message: https://github.com/nextcloud/talk-ios/blob/df94d83f60c30d256ecb1ba1e5e50f40e16491c0/NextcloudTalk/NCChatController.m#L130 so we always have the parent in store

[mahibi]

i can't reproduce the empty quoting. @GretaD @AndyScherzinger does it happen always for you or sometimes?

[AndyScherzinger]

Doesn't happen all the time. To me only happened in the beginning. By now I am running latest master and haven't experienced it again (maybe due to @rapterjet2004 comment).