Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check overwritten CSS rules #7847

Open
nickvergessen opened this issue Sep 1, 2022 · 3 comments
Open

Check overwritten CSS rules #7847

nickvergessen opened this issue Sep 1, 2022 · 3 comments

Comments

@nickvergessen
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Since the Vue 7 update was made and a lot of issues were solved by simply removing CSS blocks which we had overwriting component stuff we should make a trip through all of them and see what we should do with them:

  • ❌ Remove
  • 🆙 Upstream
  • ⏯️ Keep
@nickvergessen
Copy link
Member Author

Especially v-deeps should be checked (see #2623 ) but not only.

@Antreesy
Copy link
Contributor

Antreesy commented Oct 4, 2023

@ShGKme
Copy link
Contributor

ShGKme commented Aug 7, 2024

  • NcAppContent
    • custom styles in a call
  • NcEmptyContent - many places
  • NcRichContentEditable
    • MentionBubble on RTL
    • Emoji button support
  • NcAvatar
    • AvatarWrapper
    • and other places
  • NcActions
    • custom styling in MessageButtonBar
    • NcActionButton with danger style in Conversation.vue menu
  • Dialogs and Modals in many places
  • NcSettingdDialog - ConversationSettings
  • NcSelect - MediaDeviceSelector width: 100%
  • NcCheckboxRadioSwitch - MediaSettings - checkbox-radio-switch__label in focus in warning
  • NcListItem - some custom styling in participants
  • NcAppSidebar - many custom styles
  • NcButton
    • CallTime
    • LeftSidebar - .invitation-button
  • Fields
    • SearchBox
    • TurnServer in error state

@nickvergessen nickvergessen removed this from the v20.0.0-rc.1 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants