fix: wrong attendance status for imip events #10024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
changed the title
kesselb
force-pushed
the
bug/noid/imip-for-external-organizers
branch
from
5c67f66
to
880eca7
Compare
kesselb
force-pushed
the
perf/noid/improve-imip-calendar-integration
branch
from
d677ce7
to
59caea8
Compare
One may have imported an event, but the attendance status is not properly fetched when rendering the email. The reason is a timing / state problem. - Loading the user principal and collections is initialized in https://github.com/nextcloud/mail/blob/6fc45eb0630b9065f9ccb4c1da5cc9557f7df834/src/App.vue#L49-L50. - If the backend request for the message body is faster, than loading the principal and collections, then Imip.fetchExistingEvent runs without having calendars and changes existingEventFetched to true that prevents the method from running again. - Solution: Render the imip component when principal and collections are fetched. Signed-off-by: Daniel Kesselberg <[email protected]>
Accepting a calendar invitation should always go to a writable calendar, and therefore we can skip the check if the event exists in a read-only calendar. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
perf/noid/improve-imip-calendar-integration
branch
from
59caea8
to
4296585
Compare
ChristophWurst
approved these changes
Aug 22, 2024
st3iny
approved these changes
Sep 2, 2024
|
/backport to stable3.7 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The attendence status for an imip event might be wrong.
Before
Screencast.from.2024-08-20.13-53-29.webm
After
Screencast.from.2024-08-20.13-52-35.webm
Commit a1ecb2e
One may have imported an event, but the attendance status is not properly fetched when rendering the email.
The reason is a timing / state problem.
mail/src/App.vue
Lines 49 to 50 in 6fc45eb
Commit d677ce7
Accepting a calendar invitation should always go to a writable calendar, and therefore we can skip the check if the event exists in a read-only calendar.