Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipient info next to mail composer #9622

Closed
jancborchardt opened this issue May 2, 2024 · 7 comments · Fixed by #9824
Closed

Recipient info next to mail composer #9622

jancborchardt opened this issue May 2, 2024 · 7 comments · Fixed by #9824
Assignees
Labels
3. to review enhancement skill:backend Issues and PRs that require backend development skills skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@jancborchardt
Copy link
Member

jancborchardt commented May 2, 2024

Is your feature request related to a problem? Please describe.

When you write a mail to someone or reply, you only have the mail itself as context. You don’t see anything about the person itself except maybe if they have a signature.

Describe the solution you'd like

We could show their contact info next to the composer. Maybe you have some notes in their contact which are relevant for that, or their company name and position. I remember some mail app did this but can not recall which.

Here is a quick mockup for the contact info showing on the right side of the composer.

  • If there is only one person, just show their info right away
  • For multiple people, we could collapse it to just the avatar, main line with name and subline with title, and make it expandable
  • Data can come from Profile and/or Contacts (see below)

Mail composer contacts info

Describe alternatives you've considered

In Talk for example we will likely have to use the Profile info instead of the Contacts info. So to keep things consistent, maybe it’s better to use the same for both.
Although for Mail we need to have Contacts as a fallback since otherwise this feature would not work for external people to your organization, nor for single-user instances.

@nickvergessen said we should have a unified endpoint as an OCS API for this, so it would probably best for you to coordinate there @ChristophWurst.

Additional context

Very similar issue in Talk as well for showing additional info of a person when starting a chat: nextcloud/spreed#6293

@jancborchardt jancborchardt moved this to 🧭 Planning evaluation / ideas in 🖍 Design team May 2, 2024
@jancborchardt jancborchardt changed the title Contact info next to mail composer Recipient info next to mail composer May 2, 2024
@ChristophWurst ChristophWurst added 1. to develop skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills skill:backend Issues and PRs that require backend development skills blocked and removed 0. to triage labels May 2, 2024
@jancborchardt jancborchardt self-assigned this May 7, 2024
@jancborchardt jancborchardt moved this from 🧭 Planning evaluation / ideas to 🏗️ At engineering in 🖍 Design team May 7, 2024
@GretaD
Copy link
Contributor

GretaD commented Jun 27, 2024

@nickvergessen said we should have a unified endpoint as an OCS API for this, so it would probably best for you to coordinate there @ChristophWurst.

we should start with that i assume, how should we handle this? @ChristophWurst @nickvergessen

@ChristophWurst ChristophWurst self-assigned this Jul 2, 2024
@ChristophWurst
Copy link
Member

We can use CardDAV to search for a contact. Alternatively we could use the contacts menu endpoint.

@ChristophWurst
Copy link
Member

We have an existing endpoint for contacts. @GretaD use findMatches of src/service/ContactIntegrationService.js

@ChristophWurst
Copy link
Member

On a second look the API is insufficient. It does not expose all vcard properties.

@ChristophWurst
Copy link
Member

We can do it like #9890. It's not a lot of code and avoids creating an API for an API that already exists. We get access to the full VCARD, so all properties that might be set for a contact.

@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Dec 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Dec 18, 2024
@ChristophWurst
Copy link
Member

nextcloud/documentation#12388 is not in yet.

@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do in 💌 📅 👥 Groupware team Dec 19, 2024
@ChristophWurst ChristophWurst moved this from 📄 To do to 🏗️ In progress in 💌 📅 👥 Groupware team Dec 19, 2024
@GretaD
Copy link
Contributor

GretaD commented Dec 19, 2024

nextcloud/documentation#12388 is not in yet.

merged

@GretaD GretaD closed this as completed Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement skill:backend Issues and PRs that require backend development skills skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

3 participants