Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors after using the advanced permissions of Groupfolder master branch #3310

Closed
nabim777 opened this issue Oct 3, 2024 · 3 comments · Fixed by #3311
Closed

Errors after using the advanced permissions of Groupfolder master branch #3310

nabim777 opened this issue Oct 3, 2024 · 3 comments · Fixed by #3311
Assignees
Labels
2. developing Items that are currently under development bug

Comments

@nabim777
Copy link

nabim777 commented Oct 3, 2024

Summary

The GroupFolders app gets an error after setting advanced permissions for a folder, causing the folder to disappear. This also affect in the server(Nextcloud), when trying to list the user gets an error.

Environment Details

Nextcloud: Stable 31 (master)
GroupFolders App: master
PHP Version: 8.2
Operating System: ubuntu 22.04

Step to Reproduce

  1. Use the latest commit of the groupfolder master branch.
  2. Go to the Groupfolder UI
  3. Create a folder named demo.
  4. Assign the group admin to the folder demo.
  5. Navigate to the Advanced Permissions tab for the folder and add admin (user) with advance permission.
  6. The app crashes, the folder demo disappears, and an error occurs when trying to view all accounts.

Screen record

Screencast.from.10-03-2024.01.04.24.PM.webm

Server logs

{
  "reqId": "Zv5AY7zDm6l4DkMQNTmitQAAAAc",
  "level": 3,
  "time": "2024-10-03T06:57:39+00:00",
  "remoteAddr": "::1",
  "user": "admin",
  "app": "PHP",
  "method": "GET",
  "url": "/stable31/ocs/v2.php/cloud/groups/admin/users/details?offset=0&limit=25&search=",
  "message": "Declaration of OCA\\GroupFolders\\ACL\\ACLStorageWrapper::getDirectoryContent($directory): Traversable|false must be compatible with OC\\Files\\Storage\\Wrapper\\Wrapper::getDirectoryContent($directory): Traversable at /home/nabin/www/stable31/apps/groupfolders/lib/ACL/ACLStorageWrapper.php#303",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36",
  "version": "31.0.0.3",
  "data": {
    "app": "PHP"
  }
}

finding

I think this issue is due to return type changes on this PR which was merged 2 days ago on server nextcloud/server#48454

@nabim777 nabim777 added 0. Needs triage Issues that need to be triaged bug labels Oct 3, 2024
@provokateurin
Copy link
Member

Sorry, I know about this but didn't have the time to fix it yet. I'm on it now 👍

@provokateurin provokateurin self-assigned this Oct 3, 2024
@provokateurin provokateurin added 2. developing Items that are currently under development and removed 0. Needs triage Issues that need to be triaged labels Oct 3, 2024
@provokateurin
Copy link
Member

You can use the branch of #3311 until it is merged.

@nabim777
Copy link
Author

nabim777 commented Oct 3, 2024

Oh! Thanks for your quick response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Items that are currently under development bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants