Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many wordings have never been translated because they're not in Transifex #3130

Closed
Jerome-Herbinet opened this issue Aug 21, 2024 · 6 comments · Fixed by #3191
Closed

Many wordings have never been translated because they're not in Transifex #3130

Jerome-Herbinet opened this issue Aug 21, 2024 · 6 comments · Fixed by #3191

Comments

@Jerome-Herbinet
Copy link
Member

Jerome-Herbinet commented Aug 21, 2024

Here are at least 3 old issues talking about untranslated wordings.

They don't appear in Transifex despite a supposed (IMO, but I'm maybe mistaking) good syntax : #2131, #2372, #2166

I took an overview of the situation concerning untranslated wordings (seen in GF 18.0.0 / 17.0.2 / 16.0.7 ...) :

  • "Users/groups that can manage" (placeholder)
  • "Unlimited" and "Other ..." (quota dropdown)
  • To this, another translation isn't visible in Transifex :
    2024-08-21_16-05

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
@Jerome-Herbinet Jerome-Herbinet added bug 0. Needs triage Issues that need to be triaged labels Aug 21, 2024
@Jerome-Herbinet
Copy link
Member Author

@icewind1991 ? @jancborchardt ?
This is not a critical problem, but it has been hampering the administration of group files for non-English speakers for years.

@jancborchardt
Copy link
Member

Yes, should of course be translatable. FYI @icewind1991 @skjnldsv @sorbaugh

@smarinier
Copy link
Contributor

@joshtrichards @jancborchardt this look (at least partially) like the same issue we just met with "bbb integration" ( littleredbutton/cloud_bbb#261 ): indeed, as the front of groupfolders is based on React, it uses backticks that are very badly handled by xgettext. When i run the "check-files" options from translationtool.phar, it describes the problems and the lines that is the source of the bug (that seem to feet with Jerome feedback):

** Warning : Check potentially missing translations sentences : groupfolders /var/www/html/nc29-dev/apps-writable/groupfolders/src/settings/App.tsx
> Starting at line 290
  -> t('groupfolders', 'Advanced permissions allows setting permissions on a per-file basis but comes with a performance overhead')
  -> t('groupfolders', 'Advanced permissions are only supported with Nextcloud 16 and up')
> Starting at line 298
  -> t('groupfolders', 'Delete')
  -> t('groupfolders', 'Folder name')
  -> t('groupfolders', 'Quota')
  -> t('groupfolders', 'Advanced Permissions')
  -> t('groupfolders', 'Folder name')
  -> t('groupfolders', 'Create')
  -> t('groupfolders', 'User')
  -> t('groupfolders', 'Group')
  -> t('groupfolders', 'Users/groups that can manage')

So i propose a very simple PR #3191 .

Note : maybe NextCloud should communicate to "React front apps" so that they should check their translations with translationtool ? (Do NextCloud know wich ones are using react ?)

@provokateurin provokateurin linked a pull request Sep 10, 2024 that will close this issue
@joshtrichards
Copy link
Member

Thanks, @smarinier!

Note : maybe NextCloud should communicate to "React front apps" so that they should check their translations with translationtool ? (Do NextCloud know wich ones are using react ?)

At least within the project itself a quick and dirty search shows only groupfolders and whiteboard.

@smarinier
Copy link
Contributor

At least within the project itself a quick and dirty search shows only groupfolders and whiteboard.

I just have a quick look. Whiteboard does not have l10n folder, neither seems to be linked to nextcloud transifex repository. And at least the translationtool doesn't seem to work on it. But it appears to be a very recent project (may 2024 ?)

@joshtrichards
Copy link
Member

Good point. I was only looking for indications of React usage. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants