Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce white space between questions #1658

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Reduce white space between questions #1658

merged 1 commit into from
Jun 30, 2023

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Jun 27, 2023 •
edited
Loading

Fixes #1234 by reducing the margin on the bottom of the questions from 80px to 64px

80px 70px 60px 50px
grafik grafik grafik grafik

@Chartman123 Chartman123 self-assigned this Jun 27, 2023
@Chartman123 Chartman123 added this to the 3.4 milestone Jun 27, 2023
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 29, 2023
@Chartman123 Chartman123 marked this pull request as ready for review June 29, 2023 08:25
susnux
susnux approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but for me 50px is the minimum.

@Chartman123
Copy link
Collaborator Author

I think this is fine, but for me 50px is the minimum.

I also experimented with smaller values and evaluated 50 px to be the smallest that still looks ok.

nimishavijay
nimishavijay reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great screenshots! :) I would vote for slightly more than 50px, maybe 64px, what do you think? This is 8px more than the height of each navigation item on the left. We don't want to get rid of too much whitespace either, especially on mobile where it can easily look too cramped. Also, we should make sure that this spacing accurately reflects for all the modes (view, edit and results)

@Chartman123
Copy link
Collaborator Author

@nimishavijay thank you for the review. View/edit use the same spacing between the questions. For the results the elements are placed differently and I think that we can leave this the way it is currently. So I will change it to 64px and then we should be good to go here 😇

@Chartman123
Reduce white space between questions
a1f9a78 
Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 merged commit e3e1e1e into main Jun 30, 2023
25 checks passed
@Chartman123 Chartman123 deleted the fix/reduce-deadspace branch June 30, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay left review comments

@susnux susnux susnux approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@jotoeri jotoeri Awaiting requested review from jotoeri

Assignees

@Chartman123 Chartman123

Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request feature: 📑 form creation feature: 📝 submitting responses
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

Reduce Vertical Dead Space
3 participants
@Chartman123 @susnux @nimishavijay