Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jump to file error #89

Closed
wants to merge 1 commit into from
Closed

Conversation

R0Wi
Copy link
Member

@R0Wi R0Wi commented Apr 15, 2020

Fix #88

@hashworks
Copy link

hashworks commented Jun 7, 2020

While for me the error is gone with this fix, clicking on files still does nothing.
EDIT: This could be related to #83.

@R0Wi
Copy link
Member Author

R0Wi commented Jun 7, 2020

@hashworks do you mean you're not seeing the error in the console anymore but the click on a search- result still doesn't jump to the file? Which version of nextcloud do you use?

@hashworks
Copy link

Exactly. 19 – so yeah, could be because of that.

@R0Wi
Copy link
Member Author

R0Wi commented Jun 7, 2020

Did a quick setup with NC 19 but for me it's still working. So if there's a default-fileaction registered by any app (e.g. for viewing an image) this one opens. Otherwise a new tab is opened and you're navigated to the folder containing the file and the file is then focussed afterwards. Do you see any other errors showing up in your console? And could you try to search for a file with a special mimetype where no default app is registered an click on that one (e.g. a word-document if you haven't installed Collabora or something else. So a filetype which would usually be downloaded and not opened inside NC)? And could you tell us which is the mimetype of the file you can't jump to?

@hashworks
Copy link

Just checked, stuff like Markdown or Image files work fine. The files that fail to open are docx, which should be opened in Collabora – as I mentioned before, that might be related to #83, not this issue :)

Besides the general $ is deprecated warnings I get no console messages. There are no network connections either.

@R0Wi
Copy link
Member Author

R0Wi commented Jun 7, 2020

I see :-) What i observed is that the fulltext app provides less information about the clicked file than the regular files view. So the solution of nextcloud/files_photospheres#52 might also be interesting by the way.

@MorrisJobke MorrisJobke removed their request for review July 2, 2020 22:00
@R0Wi
Copy link
Member Author

R0Wi commented Oct 7, 2023

Seems to be fixed in newer versions of NC without changing the code. Closing

@R0Wi R0Wi closed this Oct 7, 2023
@R0Wi R0Wi deleted the bugfix/jump_to_file branch October 7, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot jump to file
2 participants