Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space between number and unit in NsColorPicker, syntax error? v8.22.0 #6510

Open
rotdrop opened this issue Feb 12, 2025 · 1 comment
Open
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: colorpicker Related to the colorpicker component

Comments

@rotdrop
Copy link

rotdrop commented Feb 12, 2025

Is not the space between "10" and "px" in these lines a syntax error?

width: calc(var(--default-clickable-area) - 10 px);
height: calc(var(--default-clickable-area) - 10 px);

It can also be found in the distribution assets.

There also seems to be a left-over scss variable $desc-height on line 176 in the npm distribution in the file

node_modules/@nextcloud/vue/dist/assets/NcAppSidebar-BntAj6H-.css

.app-sidebar .app-sidebar-header--compact.app-sidebar-header--with-figure .app-sidebar-header__info .app-sidebar-header__figure[data-v-a6baa268] {
  --figure-size: calc($desc-height + var(--app-sidebar-padding));

My apologies these are non-errors and a misinterpretation on my side.

@susnux susnux added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: colorpicker Related to the colorpicker component labels Feb 12, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Feb 13, 2025

These properties are actually ignored anyway, overwritten by the library. And applying them doesn't look good. I'd just remove these lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: colorpicker Related to the colorpicker component
Projects
None yet
Development

No branches or pull requests

3 participants