Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcAppNavigationSearch: No visual label #5885

Open
susnux opened this issue Jul 29, 2024 · 4 comments
Open

NcAppNavigationSearch: No visual label #5885

susnux opened this issue Jul 29, 2024 · 4 comments
Labels
0. to triage bug Something isn't working design Design, UX, interface and interaction design

Comments

@susnux
Copy link
Contributor

susnux commented Jul 29, 2024

Bug description

image

Steps to reproduce

  1. Open /apps/files
  2. Enter text at the top left search input

Expected behavior

Input label moves up (lie NcInputField)

@susnux susnux added bug Something isn't working design Design, UX, interface and interaction design 0. to triage labels Jul 29, 2024
@susnux
Copy link
Contributor Author

susnux commented Jul 29, 2024

I am not sure we need this for a11y, so up for @nextcloud-libraries/designers to decide.

@marcoambrosini
Copy link
Contributor

A permanent magnifying glass icon on the left should meet our accessibility requirements

@ShGKme
Copy link
Contributor

ShGKme commented Jul 30, 2024

I am not sure we need this for a11y

I remember we discussed it, and the decision was that we don't. Same as with new message input in Talk, it's "understandable" in this context.

Maybe we should add a search icon?

@marcoambrosini
Copy link
Contributor

marcoambrosini commented Jul 30, 2024

Yes, either label or icon are needed, icon would be best here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. to triage bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Development

No branches or pull requests

3 participants