New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(902): select panel with min and max size #903

Draft

mutebg wants to merge 1 commit into main from feat/902-select-panel-size

Contributor

mutebg commented Jun 15, 2023

closes #902

What

Background - we need different size on the panel
What did you do - added min and max width to the select panel, that way consumers can have more control of its size
What does the reviewers should expect

I have done:

Written unit tests against changes
Written functional tests against the component and/or NewsKit site
Updated relevant documentation

I have tested manually:

The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
The screen reader reads and flows through the elements as expected.
There are no new errors in the browser console coming from this PR.
When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:


          feat(902): select panel with min and max size

3ddcf54

github-actions bot added the feature label

Collaborator

pp-serviceaccount commented Jun 15, 2023

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/902-select-panel-size
Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/902-select-panel-size/storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature