enable working with percentiles #40
Conversation
|
|
There was a problem hiding this comment.
Hello @dulcineapena1,
Thank you for your pull request and I apologize for the delay in my response.
I just checked your code, ran it and encountered a ReferenceError specifically
Uncaught ReferenceError: cells is not defined
at EditBoard.render
The above should be an easy fix on your part. However, I am still unsure by what you are trying to achieve. You are adding functionality that enables working with percentiles. Can you explain further what you expect to achieve? Are the percentiles the output of the board? Appreciate you taking the time to explain.
I
|
Hello @glitton Talking about the explanation that you ask me, I notice when I try to work with percentiles, I got a blank cell instead of the bullet or the value. For example if I select an event type SystemSample, attribute median(cpuSystemPercent), I will have a blank cell in my board; and in case I add a comparison less than 1, my entire board will crash with the message 'Oops! Something went wrong.' I mean, I would expect to have a bullet in my board, similar that the ones you get when you are working with another type of attribute. Thanks for your time! |
|
@glitton Any thoughts on @dulcineapena1's latest comment? |
|
This seems like a stale PR, so I'll close unless someone can confirm this is still being worked on. |
@jpvajda |
|
@dulcineapena1 ok thanks for confirming. |
Releted to #39
Add the hability to work with percentiles attributes values.