You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is likely a problem in the Java Agent as well...
The OpenTelemetry Ruby SQL obfuscation and statement extraction code was largely a copy-paste project from the New Relic Ruby agent. While refactoring that code in open-telemetry/opentelemetry-ruby-contrib#529, we discovered statement extraction and SQL obfuscation needed some tweaking when sqlcommenter was used.
I verified our existing SQL obfuscation code properly handles prepended SQLCommenter comments. Manually copied the new cross agent test cases into the SQLObfuscator test and all passed.
This is likely a problem in the Java Agent as well...
The OpenTelemetry Ruby SQL obfuscation and statement extraction code was largely a copy-paste project from the New Relic Ruby agent. While refactoring that code in open-telemetry/opentelemetry-ruby-contrib#529, we discovered statement extraction and SQL obfuscation needed some tweaking when sqlcommenter was used.
Commit where edge case was discussed: open-telemetry/opentelemetry-ruby-contrib@b8b2605 (look at resolved discussions)
Commit with fix: open-telemetry/opentelemetry-ruby-contrib@82584ba
This PR adds test cases to the cross-agent tests to cover sqlcommenter.
Source: https://source.datanerd.us/agents/cross_agent_tests/pull/155
The text was updated successfully, but these errors were encountered: