Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sqlcommenter style comments #1905

Closed
jbedell-newrelic opened this issue May 21, 2024 · 2 comments
Closed

Support sqlcommenter style comments #1905

jbedell-newrelic opened this issue May 21, 2024 · 2 comments
Assignees
Labels
1 Story Point Estimate

Comments

@jbedell-newrelic
Copy link
Contributor

This is likely a problem in the Java Agent as well...

The OpenTelemetry Ruby SQL obfuscation and statement extraction code was largely a copy-paste project from the New Relic Ruby agent. While refactoring that code in open-telemetry/opentelemetry-ruby-contrib#529, we discovered statement extraction and SQL obfuscation needed some tweaking when sqlcommenter was used.

Commit where edge case was discussed: open-telemetry/opentelemetry-ruby-contrib@b8b2605 (look at resolved discussions)
Commit with fix: open-telemetry/opentelemetry-ruby-contrib@82584ba
This PR adds test cases to the cross-agent tests to cover sqlcommenter.

Source: https://source.datanerd.us/agents/cross_agent_tests/pull/155

@workato-integration
Copy link

@jtduffy jtduffy moved this from Triage to In Quarter in Java Engineering Board Jun 14, 2024
@jtduffy jtduffy self-assigned this Jun 14, 2024
@jtduffy jtduffy moved this from In Quarter to In Sprint in Java Engineering Board Jun 14, 2024
@jtduffy jtduffy added the 1 Story Point Estimate label Jun 14, 2024
@jtduffy
Copy link
Contributor

jtduffy commented Jun 14, 2024

I verified our existing SQL obfuscation code properly handles prepended SQLCommenter comments. Manually copied the new cross agent test cases into the SQLObfuscator test and all passed.

Image

@jtduffy jtduffy closed this as completed Jun 14, 2024
@github-project-automation github-project-automation bot moved this from In Sprint to Code Complete/Done in Java Engineering Board Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Story Point Estimate
Projects
Archived in project
Development

No branches or pull requests

2 participants