Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value for JetPack Boost #76

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Set default value for JetPack Boost #76

wants to merge 7 commits into from

Conversation

AleTorrisi
Copy link
Contributor

This little changes wants enable by default CSS & JS minification on Jetpack Boost just for fresh installations

Proposed changes

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

arunshenoy99
arunshenoy99 reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AleTorrisi Just a few small changes needed and a question, everything else looks good to me. Thanks!

arunshenoy99
arunshenoy99 reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving all Jetpack Boost-related features to a new JetpackBoost feature class, similar to LinkPrefetch or Images? This will help keep the code in one place and make it more organized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmiles chrisdavidmiles chrisdavidmiles left review comments

@arunshenoy99 arunshenoy99 arunshenoy99 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AleTorrisi @chrisdavidmiles @arunshenoy99