Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enabler] Filtering events - refactor code #35

Open
2 tasks
glass-ships opened this issue Dec 17, 2024 · 1 comment
Open
2 tasks

[Enabler] Filtering events - refactor code #35

glass-ships opened this issue Dec 17, 2024 · 1 comment

Comments

@glass-ships
Copy link
Member

'- doc update on EventList:FilterInPlace: GitHub issue/pull request detail

  • copy_if: GitHub issue/pull request detail

Description:

This will prepare mantid for the new way of filtering logs as detailed in the design document.

The work focuses on modifying private methods in DataObjects::EventList to use Kernel::TimeROI, plus a few small changes.

This enabler will cover step 6 of the "implementation notes" section of the design document.

Outline of activity:

* [ ] Add erase_if method to DataObjects::EventList

  • Add copy_if method to DataObjects::EventList
  • Replace the private methods
    • filterByPulseTimeHelper: should be replaced with the copy_if
    • filterByTimeAtSampleHelper: should be replaced with the copy_if
    • filterInPlaceHelper: should be refactored following maskTOF example
  • [ ] Changes to Instrument
  • [ ] Changes to Goniometer
@glass-ships
Copy link
Member Author

This issue was migrated from code.ornl.gov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant