[WIP]: webpack bundler added #252
Conversation
There was a problem hiding this comment.
Hello @viralgupta, thanks for sending this PR. Could you please compare the benefits of using https://www.npmjs.com/package/node-minify. Seems like it supports wildcard path matches, so we don't need to parse index.html manually. Thanks 🎉
There was a problem hiding this comment.
I'm against this and any PRs that arbitrarily mangle user's input. If I was a maintainer, I would veto it. If I was a user with that PR merged, I would simply not use Neutralino.js. Everyone uses their preferable build tools already and having the slowest and oldest possible packer mangle scripts is pointless, dangerous, and inflexible.
- Bundling JS files just to minify them in one file is one of the least concerns when developing a desktop app.
- ESM vs IIFE-type scripts are not handled here;
- No way to configure path rewriting and external modules;
- It's slow, there're dozens of popular options in the wild like vite, rollup, esbuild, etc.;
- And the end user knows what to use better anyways.
- And, really, Webpack? in 2024?!
|
Hi @CosmoMyzrailGorynych, Please note: This was my first time contributing to open source, and I wanted to close issues quickly and genuinely wanted to help the community. However, I had little to no knowledge of the available bundling technologies when I created this PR. I apologize for any inconvenience caused. |
|
That's ok, I'm glad you're growing as a developer. |
Right now we are building binaries from raw javascript files given, this pr helps to reduce app size a bit by bundling js files.
i have tested with few apps and is working fine, @shalithasuranga could you also review this on your machine.
may-resolve #78