Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NB_API_QUERY_URL to NB_API_URL or similar #82

Open
alyssadai opened this issue Aug 16, 2024 · 0 comments
Open

Rename NB_API_QUERY_URL to NB_API_URL or similar #82

alyssadai opened this issue Aug 16, 2024 · 0 comments
Labels
maint:refactor Simplifying or restructuring existing code or documentation. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@alyssadai
Copy link
Contributor

NB_API_QUERY_URL can be slightly confusing because it:

  1. Does not refer to the query tool URL
  2. Does not refer only to the /query endpoint for the API, rather it is the base URL for the API which endpoints are appended to

To improve clarity and prevent confusion with NB_QUERY_APP_BASE_PATH, maybe we can consider renaming this to simply NB_API_URL or NB_FAPI_URL.

@alyssadai alyssadai added maint:refactor Simplifying or restructuring existing code or documentation. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maint:refactor Simplifying or restructuring existing code or documentation. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: No status
Development

No branches or pull requests

1 participant