You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our Auth e2e test in #300 is failing because the warning popup for "we removed some diagnostics terms" is covering the login button:
Not sure what the best fix here is. The popup is on a timeout, so we could just make the cypress test wait longer than the popup timeout. Or we could actively click the popup away as part of the test setup, but that seems a little messy.
But we need to fix this before #300 can be merged.
The text was updated successfully, but these errors were encountered:
surchs
added
bug:test
Defect causing our test suite to fail, although no functional error is occurring.
type:bug
Defects in shipped code and fixes for those defects
flag:schedule
Flag issue that should go on the roadmap or backlog.
quick fix
Minimal planning and/or implementation work required.
and removed
flag:schedule
Flag issue that should go on the roadmap or backlog.
labels
Oct 8, 2024
Given this behavior is due to querying the production API (and getting missing data in response), I think a better approach would be to mock the response to fix this bug. wdyt @surchs ?
Hhm, yes, I agree that in this case we should mock the call because we don't want to rely on the prod API for the tests to run.
But as we have discovered the more general issue of warning prompts hiding important UI elements, we still have to address the original issue - so it doesn't come back.
How about we do this:
Make a new issue to mock all API calls instead of relying on the prod API
Put that new issue high on the backlog directly
Move this current issue off the backlog but keep it open as a reminder to fix the general issue of warnings overlapping UI
Our Auth e2e test in #300 is failing because the warning popup for "we removed some diagnostics terms" is covering the login button:
Not sure what the best fix here is. The popup is on a timeout, so we could just make the cypress test wait longer than the popup timeout. Or we could actively click the popup away as part of the test setup, but that seems a little messy.
But we need to fix this before #300 can be merged.
The text was updated successfully, but these errors were encountered: