Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notistack popups overlapping UI elements #306

Open
surchs opened this issue Oct 8, 2024 · 3 comments
Open

Notistack popups overlapping UI elements #306

surchs opened this issue Oct 8, 2024 · 3 comments
Labels
bug:test Defect causing our test suite to fail, although no functional error is occurring. type:bug Defects in shipped code and fixes for those defects

Comments

@surchs
Copy link
Contributor

surchs commented Oct 8, 2024

Our Auth e2e test in #300 is failing because the warning popup for "we removed some diagnostics terms" is covering the login button:

Image

Not sure what the best fix here is. The popup is on a timeout, so we could just make the cypress test wait longer than the popup timeout. Or we could actively click the popup away as part of the test setup, but that seems a little messy.

But we need to fix this before #300 can be merged.

@surchs surchs added bug:test Defect causing our test suite to fail, although no functional error is occurring. type:bug Defects in shipped code and fixes for those defects flag:schedule Flag issue that should go on the roadmap or backlog. quick fix Minimal planning and/or implementation work required. and removed flag:schedule Flag issue that should go on the roadmap or backlog. labels Oct 8, 2024
@surchs
Copy link
Contributor Author

surchs commented Oct 8, 2024

Might be easiest to just wait until the warning auto-closes after 4000ms (?)

@rmanaem rmanaem self-assigned this Oct 9, 2024
@rmanaem
Copy link
Contributor

rmanaem commented Oct 9, 2024

Given this behavior is due to querying the production API (and getting missing data in response), I think a better approach would be to mock the response to fix this bug. wdyt @surchs ?

@surchs
Copy link
Contributor Author

surchs commented Oct 9, 2024

Hhm, yes, I agree that in this case we should mock the call because we don't want to rely on the prod API for the tests to run.
But as we have discovered the more general issue of warning prompts hiding important UI elements, we still have to address the original issue - so it doesn't come back.

How about we do this:

  1. Make a new issue to mock all API calls instead of relying on the prod API
  2. Put that new issue high on the backlog directly
  3. Move this current issue off the backlog but keep it open as a reminder to fix the general issue of warnings overlapping UI

@rmanaem rmanaem removed the quick fix Minimal planning and/or implementation work required. label Oct 9, 2024
@rmanaem rmanaem changed the title e2e tests fail because warning covers login button Notistack popups overlapping UI elements Oct 9, 2024
@rmanaem rmanaem removed their assignment Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:test Defect causing our test suite to fail, although no functional error is occurring. type:bug Defects in shipped code and fixes for those defects
Projects
Status: No status
Development

No branches or pull requests

2 participants