Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subjects missing imaging session excluded from result? #331

Closed
2 tasks done
alyssadai opened this issue Aug 6, 2024 · 2 comments · Fixed by #333
Closed
2 tasks done

Subjects missing imaging session excluded from result? #331

alyssadai opened this issue Aug 6, 2024 · 2 comments · Fixed by #333
Assignees
@alyssadai
Labels
bug:functional Functional defects resulting from feature changes. released This issue/pull request has been released. type:bug Defects in shipped code and fixes for those defects

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Aug 6, 2024 •
edited
Loading

Steps to reproduce

Go to https://query.neurobagel.org and try an empty query in the QPN graph. Note that only 289/303 subjects match.

Based on query template changes introduced in #326, it is possible that subjects without imaging data are now somehow not being included in matches for the new default query.

Steps to fix

  • ensure that subjects without imaging sessions are included in query results when no filters are applied
  • regenerate default query file
@alyssadai alyssadai added bug:functional Functional defects resulting from feature changes. type:bug Defects in shipped code and fixes for those defects labels Aug 6, 2024
@alyssadai alyssadai mentioned this issue Aug 6, 2024
Closed
1 task
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Aug 6, 2024
@alyssadai alyssadai self-assigned this Aug 6, 2024
@alyssadai alyssadai mentioned this issue Aug 7, 2024
Merged
7 tasks
@alyssadai alyssadai removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Aug 7, 2024
@alyssadai
Copy link
Contributor Author

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 13, 2024
@neurobagel-bot Neurobagel Bot
Copy link

🚀 Issue was released in v0.3.1 🚀

@alyssadai alyssadai mentioned this issue Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssadai alyssadai

Labels
bug:functional Functional defects resulting from feature changes. released This issue/pull request has been released. type:bug Defects in shipped code and fixes for those defects
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Ensure subjects without imaging sessions are considered in main query neurobagel/api
1 participant
@alyssadai