Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy version to prevent tests from failing #320

Closed
rmanaem opened this issue Jun 26, 2024 · 1 comment
Closed

Pin numpy version to prevent tests from failing #320

rmanaem opened this issue Jun 26, 2024 · 1 comment
Assignees
Labels
maint:dependency Dependency updates and their version upgrades. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@rmanaem
Copy link
Collaborator

rmanaem commented Jun 26, 2024

Our test workflow is failing

Image

and it seems to be due to the major version bump in numpy: https://stackoverflow.com/questions/78634235/numpy-dtype-size-changed-may-indicate-binary-incompatibility-expected-96-from

See affected PRs: #317, #318, #319

To resolve this issue, we will pin the numpy version to the latest version 1 (1.24.6) on a separate branch and then merge that branch into those PRs. This way there will be no conflict and there will be no need for a review on a separate PR that would otherwise be made for this issue.

@rmanaem rmanaem self-assigned this Jun 26, 2024
@rmanaem rmanaem added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:dependency Dependency updates and their version upgrades. labels Jun 26, 2024
@rmanaem
Copy link
Collaborator Author

rmanaem commented Jun 26, 2024

Closing this since the issue has been addressed and the PRs were merged with green status on the test workflow.

@rmanaem rmanaem closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maint:dependency Dependency updates and their version upgrades. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: Review - Done
Development

No branches or pull requests

1 participant