Possibility of DB corruption

[kshpytsya]

Since it is perfectly acceptable for open to return 0 ("The return value of open() is a file descriptor, a small, nonnegative integer" ¹), self.fd may be set to 0 in the following line:

magnitude/pymagnitude/__init__.py

Line 279 in 5f063ec

self.fd = os.open(self.path, os.O_RDONLY)

This is highly possible in non-interactive Docker environment, when there is no stdin open.

Incorrect condition in the following line (which should be written as self.fd is not None instead):

magnitude/pymagnitude/__init__.py

Line 454 in 5f063ec

if self.fd:

causes wiping of the DB via self._create_empty_db call.

Footnotes

1. man open ↩