Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transport telnet #64

Open
lethalwp opened this issue Jul 20, 2020 · 2 comments
Open

add transport telnet #64

lethalwp opened this issue Jul 20, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@lethalwp
Copy link

This is maybe a bit dirty.
To facilitate the telnet "transport" instead of ssh.
When port 23 is selected, add automatically the transport:telnet option

diff:
--- a/netbox_onboarding/onboard.py
+++ b/netbox_onboarding/onboard.py
@@ -321,6 +321,10 @@ class NetdevKeeper:
driver = get_network_driver(driver_name)
optional_args = settings.NAPALM_ARGS.copy()
optional_args["secret"] = self.secret
+

  •        if self.ot.port == 23:
    
  •           optional_args["transport"] = "telnet"
    
  •        dev = driver(
               hostname=mgmt_ipaddr,
               username=self.username,
    
@dgarros
Copy link
Contributor

dgarros commented Jul 20, 2020

Thanks @lethalwp, would you mind creating a PR for it ?

Also, thanks for using the template for issue in the future.

@dgarros dgarros added the enhancement New feature or request label Jul 20, 2020
@Kani999
Copy link

Kani999 commented May 5, 2021

@dgarros

  • Change transport protocol #140
  • I didn't find out, how to pass NAPALM arguments to platform and get it work with onboarding plugin. So I've edited the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants