Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need to call add_child AND add #239

Open
Kircheneer opened this issue Aug 15, 2023 · 0 comments
Open

Remove need to call add_child AND add #239

Kircheneer opened this issue Aug 15, 2023 · 0 comments
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement
Milestone
2.0.0

Comments

@Kircheneer
Copy link
Collaborator

Environment

  • DiffSync version:

Proposed Functionality

Have add_child implicitly call add, removing the need for both calls.

Use Case

I don't think there is use in doing both separately as they always have to be done anyway, this would make the interface easier.
@Kircheneer Kircheneer added status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement labels Aug 15, 2023
@Kircheneer Kircheneer added this to the 2.0.0 milestone Aug 18, 2023
@jamesharr jamesharr mentioned this issue Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@Kircheneer