Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework some steps in resolve-conflicts workflow #84

Open
NikitaSkrynnik opened this issue Aug 9, 2024 · 0 comments
Open

Rework some steps in resolve-conflicts workflow #84

NikitaSkrynnik opened this issue Aug 9, 2024 · 0 comments

Comments

@NikitaSkrynnik
Copy link
Contributor

Description

We need to rework this condition in resolve-conflict workflow. This condition checks if the workflow has already tried to resolve conflicts in previous 10 commits. The problem is if a PR has less then 10 commits then the condition also checks main branch. If there are resolved conflicts from other PRs in the main branch they will be taken into account too. Therefore, sometimes this workflow doesn't work because of other PRs.

Issue

networkservicemesh/cmd-forwarder-vpp#1102

Solution

We can use

git log --oneline main..HEAD

to get commits only from the current barnch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant