Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractMemoryHttpData performance issue when using composite buffer #6

Open
pderop opened this issue Aug 16, 2022 · 1 comment
Open
Labels
enhancement New feature or request
Milestone

Comments

@pderop
Copy link
Collaborator

pderop commented Aug 16, 2022

Buffers appended to the AbstractMemoryHttpData are appended to a CompositeBuffer using "extendWith" method.
But it seems there is a performance issue with extendsWith method. Maybe the CompositeBuffer API is not used appropriately or maybe there is room for optimisation in the CompositeBuffer implementation, I don't know for the moment.

I'm attaching a benchmark which is reproducing the performance issue:
buffer.composite.benchmark.tgz

here are the results, where we can observe the performance issue:

Benchmark Mode Cnt Score Error Units
MyBenchmark.compositeBufferBenchmark thrpt 14116.317 ops/s
MyBenchmark.compositeByteBufBenchmark thrpt 153964.596 ops/s

@pderop pderop added the enhancement New feature or request label Aug 22, 2022
@pderop
Copy link
Collaborator Author

pderop commented Oct 28, 2022

we should check if the recent netty issue is fixing the performance issue when using composite extendWith method (see netty PR #12759).

@pderop pderop added this to the 5.0.0.Alpha2 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant