Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

Issues with latest WMI installer #30

Open
thiagoftsm opened this issue Dec 1, 2022 · 18 comments
Open

Issues with latest WMI installer #30

thiagoftsm opened this issue Dec 1, 2022 · 18 comments

Comments

@thiagoftsm
Copy link

Issue 1

When I tried to install and claim a node today on Windows Server 2022 I received this error:

Screenshot_20221201_171850

And I could not finish installation.
After this double click installer and everything worked as expected.

Issue 2

During installation time on the same server, it cannot use WSL2 and it uses WSL1:

Screenshot_20221201_172444

I am not sure if this is an error with installer and our image, or an issue on server. 🤔

Issue 3

We are not using latest version of windows exporter. Is there a specific reason for this? I am using the latest to develop and I do not identify an error that can postpone our use.

Issue 4

@cakrit we are always installing Windows Exporter with default options instead to detect possible servers installed and enable options. Should we improve this a little bit?

@dfpr
Copy link
Contributor

dfpr commented Dec 1, 2022

Issue 1

When I tried to install and claim a node today on Windows Server 2022 I received this error:

Screenshot_20221201_171850

And I could not finish installation. After this double click installer and everything worked as expected.

MSIEXEC won't open .\netdata.msi, the correct command is msiexec.exe /i netdata.msi without the .\ prefix.
Double click will only work for the built-in administrator account that has UAC disabled.

Issue 2

During installation time on the same server, it cannot use WSL2 and it uses WSL1:

Screenshot_20221201_172444

I am not sure if this is an error with installer and our image, or an issue on server. 🤔

Server doesn't have Virtualization or Nested virtualization available so it has to use WSL1.
Task manager | Performance | CPU will say "Virtualization: Enabled" only when available.

Issue 3

We are not using latest version of windows exporter. Is there a specific reason for this? I am using the latest to develop and I do not identify an error that can postpone our use.

I guess that version was released after I started working on the installer, anyway, I have updated it to v0.20.

@thiagoftsm
Copy link
Author

Thank you for your explanation, I will keep it open until we update Windows Exporter.

@dfpr
Copy link
Contributor

dfpr commented Dec 1, 2022

Latest release includes windows exporter v0.20

@thiagoftsm
Copy link
Author

Hello @dfpr ,

Thank you to update the Windows Exporter. Now about to claim a node, we still have an issue on Windows Server, please, take a look in what happens when I use Power Shell to install:

fail

On the other hand, when I do not use additional information necessary to claim a node, the installation happens as expected:
success

Best regards!

@dfpr
Copy link
Contributor

dfpr commented Dec 1, 2022

Latest release should handle rooms with spaces in their names correctly.

@thiagoftsm
Copy link
Author

Latest release should handle rooms with spaces in their names correctly.

Yes, but I used quotes around them.

@dfpr
Copy link
Contributor

dfpr commented Dec 2, 2022

msiexec received the variable correctly but invocation of netdata-claim.sh didn't, that is fixed

@thiagoftsm
Copy link
Author

Hello @dfpr ,

Unfortunately the latest release still has the issue:

Screenshot_20221202_002511

I kept the Room name this time to help you, and I also showed part of the key too.

Best regards!

@dfpr
Copy link
Contributor

dfpr commented Dec 2, 2022

Sorry, I thought the issue was in the installation script but it is just a powershell issue: double quotes inside the command need a backtick place before: msiexec /i netdata.msi ROOMS=`"My room`" or even better don't run the command using powershell but use cmd.

@thiagoftsm
Copy link
Author

Sorry, I thought the issue was in the installation script but it is just a powershell issue: double quotes inside the command need a backtick place before: msiexec /i netdata.msi ROOMS=`"My room`" or even better don't run the command using powershell but use cmd.

Nice, now I could run the command and install netdata from Power Shell, but the VM restarted without to ask me nothing. When I ran msiexec.exe /i netdata.msi I had the expected behavior asking me to reboot.

@dfpr
Copy link
Contributor

dfpr commented Dec 2, 2022

Non-interactive restart only happened to me with the AUTORESTART=1 argument, I'll test deeper this weekend.

@thiagoftsm
Copy link
Author

Non-interactive restart only happened to me with the AUTORESTART=1 argument, I'll test deeper this weekend.

All right, thank you!
I never set AUTORESTART=1 while I was installing, probably we have something inside our codes. 🤔
Please, let me know if you need any additional information.

@dfpr
Copy link
Contributor

dfpr commented Dec 2, 2022

I could take a look at the installation log at C:\netdata.log

@thiagoftsm
Copy link
Author

Of course, this is the file we have right now at our C:.

Please, refresh my mind, on normal situation we do not store nothing in / on Unix systems, should we also have the same principle on Microsoft? Why we are not moving C:\netdata.log to C:\Netdata after installation is done?

@dfpr
Copy link
Contributor

dfpr commented Dec 5, 2022

I couldn't reproduce the issue, I'd say don't use powershell but use cmd... but let me see the Windows Installer log generated like this: msiexec /i "installer.msi" /L*v "log.log"
Also, since the installer creates C:\NETDATA and removes it at uninstallation then the log can't be saved there.

@thiagoftsm
Copy link
Author

Hello @dfpr ,

Sorry for the delay, this is the output of the command you gave me.

For the second time I had server restarting while I was installing.

About I'd say don't use powershell but use cmd, well I think we need to detect the prompt and raise a message box for users stopping the installation and redirecting them for the normal cmd.

Please, let me know if you need any other thing.

Best regards!

@dfpr
Copy link
Contributor

dfpr commented Dec 6, 2022

I'll check deeper how to avoid the issue with powershell and try to show message boxes when the command line is malformed

@dfpr
Copy link
Contributor

dfpr commented Dec 7, 2022

Problem was handing of spaces in ROOMS, it is fixed now. BUT I can't claim as the installer sends app.netdata.cloud to netdata-claim.sh but that script uses api.netdata.cloud disregarding the argument and failing to reach such address.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants