Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid validating cached terminations on Cable instance when loading serialized data #17832

Closed
jeremystretch opened this issue Oct 22, 2024 · 0 comments · Fixed by #17833
Closed

Avoid validating cached terminations on Cable instance when loading serialized data #17832

jeremystretch opened this issue Oct 22, 2024 · 0 comments · Fixed by #17833
Assignees
@jeremystretch
Labels
netbox status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

This addresses a minor issue arising from the implementation of #17577: Cable.clean() should enforce that A & B terminations are defined for an instance only if its primary key is not yet defined. If a PK is already set, this implies that the cable has been populated from serialized data, and terminations will not be set on the instance.

Justification

This change is needed to address netboxlabs/netbox-branching#155. It does not impact any functionality native to NetBox itself as far as I'm aware.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Oct 22, 2024
@jeremystretch jeremystretch self-assigned this Oct 22, 2024
jeremystretch added a commit that referenced this issue Oct 22, 2024
@jeremystretch
Closes #17832: Don't validate terminations on Cable instance when imp…
c6288c6 
…orting from serialzied data
@jeremystretch jeremystretch mentioned this issue Oct 22, 2024
Merged
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
netbox status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
1 participant
@jeremystretch