Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttachedOnEditor apparently is failing when the craft is rerooted #56

Open
Lisias opened this issue Sep 9, 2022 · 2 comments
Open

AttachedOnEditor apparently is failing when the craft is rerooted #56

Lisias opened this issue Sep 9, 2022 · 2 comments
Assignees

Comments

@Lisias
Copy link
Contributor

Lisias commented Sep 9, 2022

Fellow Kerbonaut DY_ZBX realized something interesting about merging crafts:

I did the following operations.
Re-created and saved both crafts, but still had the same problem as in the video. And I also used Craft Manager at the same time.

When I don't modify the parent part, though, the problem doesn't seem to arise.

Sounds like something missing on AtttachedOnEditor - this may be related with the original problem incepted by ModulePartVariant that was failing to initialise on some circunstaces and was bruteforced on KSP 1.4.3

@Lisias
Copy link
Contributor Author

Lisias commented Sep 9, 2022

Addendum! The problem is on rerooting the craft! After rerooting the craft we have the misbehaviour!

If you build the craft in the inverted order, even by "inverting" parts before attachment the problem doesn't happen!

@Lisias Lisias changed the title AttachedOnEditor apparently is failing when the root part is mangled somehow AttachedOnEditor apparently is failing when the craft is rerooted Sep 9, 2022
@Lisias Lisias self-assigned this Sep 9, 2022
@Lisias Lisias modified the milestones: 0.3.0.3, 0.3.0.4 Sep 9, 2022
@Lisias Lisias removed this from the 0.3.0.4 milestone Jan 27, 2023
@Lisias
Copy link
Contributor Author

Lisias commented Mar 23, 2024

I think this is a side effect of #66 (being this last one the real issue).

I will try to check this on my next Diagnosing Festival and, if proven true, I will close this one as duplicate as #66 has better Test Sessions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant