Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Driftless on KSP 1.11 and 1.12 and fix any problems #10

Open
Lisias opened this issue Dec 18, 2020 · 9 comments
Open

Check Driftless on KSP 1.11 and 1.12 and fix any problems #10

Lisias opened this issue Dec 18, 2020 · 9 comments
Assignees
Labels
task Not a problem, but something I must do and should not forget about
Milestone

Comments

@Lisias
Copy link
Contributor

Lisias commented Dec 18, 2020

As the tittle says

EDIT:

KSP 1.11 needs an specialised version of Driftless, that would act only on Yaw, as the drift itself is fixed on it.

KSP 1.12 too.

@Lisias Lisias self-assigned this Dec 18, 2020
@Lisias
Copy link
Contributor Author

Lisias commented Dec 18, 2020

This is a test of stability of landed vessels wihout KSP Recall

I reproduced a setup I had used in the past: two kerbals, two crafts.

screenshot0

And then a 3rd big one on the scene, to stress the physics engine.

screenshot1

About 10 minutes later, the Kerbals and crafts are still on their places:

screenshot2

But the big craft has drifted a lot...

screenshot3

This suggests me that;

  1. KSP Recall's Driftless is not needed on KSP 1.11
  2. KSP implemented a hack similar to Driftless, otherwise the big craft would not had drifted. :P

IMHO a proper fix would be clamping the torques on every part on the Physics engine itself, instead of zeroing them on the top level. But... I'm not the KSP developer, and I don't have all the information - so I can't criticize the solution . :)

edit: here, a KSP Team member explains the reasoning for this behaviour. Something on the PhysX engine demands a brute force solution to prevent drifting - but Squad forgot to apply it on the torque too!!!

@Lisias
Copy link
Contributor Author

Lisias commented Dec 18, 2020

Now I installed KSP Recall to check if it enhances, worse or just dry run on the same setup.

First, I replace the big craft using VesselMover (it's working fine, by the way)

screenshot6

Then I leaved the game alone for 10 minutes.

screenshot7

And then...

screenshot8

Well, the big craft drifted again, but WAY LESS than the stock solution on the Yaw axis....

@Lisias
Copy link
Contributor Author

Lisias commented Dec 18, 2020

Veredict: KSP-Recall Driftless is not needed on KSP 1.11, but it's still useful on borderline situations.

I will not prevent it from installing itself on KSP 1.11.

@Lisias
Copy link
Contributor Author

Lisias commented Dec 18, 2020

On the other hand, since Drfitless can still be useful on KSP 1.11, I think it is a good idea to further investigate if there's a way to still act when the physics engine is overloaded

@Lisias Lisias closed this as completed Dec 18, 2020
@Lisias
Copy link
Contributor Author

Lisias commented Dec 18, 2020

Post edit: Stock KSP is heavily yawing the craft.

On Driftless, the yawing is way less severe, but the craft drifted downhill (or down airstrip). This suggests Driftless would make a good use of a "anchor".

@Lisias
Copy link
Contributor Author

Lisias commented Dec 19, 2020

Squad Team provided an pretty good explanation about this here.

So... I changed my mind, I will reopen this and see how Recall could help.

@Lisias Lisias reopened this Dec 19, 2020
@Lisias Lisias changed the title Check Driftless on KSP 1.11 Check Driftless on KSP 1.11 and fix any problems Dec 19, 2020
@Lisias
Copy link
Contributor Author

Lisias commented Feb 8, 2021

Interestingly, the Stock anti-drift works most of the time - but not always.

SOME DRIFT IS STILL THERE

I just launched this monster, leaved it parked the whole morning and came back to see what I got.

screenshot31
screenshot33

The position appears to be allright, but the thing is still drifting the heading...

@Lisias Lisias modified the milestones: 0.2.0.1, 0.2.0.2 Jun 23, 2021
@Lisias Lisias changed the title Check Driftless on KSP 1.11 and fix any problems Check Driftless on KSP 1.11 and 1.12 and fix any problems Jun 27, 2021
@Lisias Lisias added the task Not a problem, but something I must do and should not forget about label Jun 27, 2021
@Lisias
Copy link
Contributor Author

Lisias commented Jun 27, 2021

Hohmanson reported that KSP 1.12 added some more drifting.

@Lisias
Copy link
Contributor Author

Lisias commented Jul 18, 2021

The heavy drifting reported on KSP 1.12 is due a less than ideal decision on the default values for some new code that, effectively, solved the problem.

Source 1

Source 2

So I'm still unsure if this should be, indeed, tackled down on Recall. I will leave this open in the mean time, just to prevent this to be forgotten.

@Lisias Lisias modified the milestones: 0.3.0.2, 0.3.0.3, 0.3.1.0 Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Not a problem, but something I must do and should not forget about
Projects
None yet
Development

No branches or pull requests

1 participant