Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on @Injectable() #13398

Closed
1 task done
bacebu4 opened this issue Apr 4, 2024 · 2 comments
Closed
1 task done

Improve documentation on @Injectable() #13398

bacebu4 opened this issue Apr 4, 2024 · 2 comments
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@bacebu4
Copy link

bacebu4 commented Apr 4, 2024

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

Documentation on why @Injectable() decorator is not clear enough in docs as well as in source code comment. For more information we can refer to this article

Describe the solution you'd like

I'd like to suggest adding more information about why @Injectable() is really needed to eliminate the confusion. What do you think about that? I can draft PR with suggestions

Teachability, documentation, adoption, migration strategy

Provided explanation in the link can be a good foundation for improving documentation

What is the motivation / use case for changing the behavior?

To eliminate the confusion on why @Injectable() decorator is needed

@bacebu4 bacebu4 added needs triage This issue has not been looked into type: enhancement 🐺 labels Apr 4, 2024
@bacebu4
Copy link
Author

bacebu4 commented Apr 4, 2024

Yeah, this is exactly that, haven't checked PRs before opening

Closing the issue, let's track progress in !2481 and hope it will land in the master branch :)

@bacebu4 bacebu4 closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Development

No branches or pull requests

2 participants