Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use HTTPS #43

Open
kcampion opened this issue Jun 4, 2014 · 4 comments
Open

Allow to use HTTPS #43

kcampion opened this issue Jun 4, 2014 · 4 comments

Comments

@kcampion
Copy link

kcampion commented Jun 4, 2014

I updated source code to allow using HTTPS. I'm on the right way?

kcampion@f0be154

@nervetattoo
Copy link
Owner

Yes, that approach should work. A bit strange to reuse the HTTP transport, and it requires you to add another constructor param to it. Its probably better to just extend it and change only the protocol part.

@kcampion
Copy link
Author

kcampion commented Sep 6, 2014

Yes, but HTTP is already extend with Base. What was your idea?

@timomayer
Copy link

will we see HTTPs support as a feature soon?

@nervetattoo
Copy link
Owner

Yes, I have a thought @kcampion

$client = Client::connection(array(
  ...
  'secure' => true
));

Then each transport can infer what secure actually means in implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants