diff --git a/docs/developer_guides/viewer/local_viewer.md b/docs/developer_guides/viewer/local_viewer.md index ef8b1ac1f9..b2a36171a1 100644 --- a/docs/developer_guides/viewer/local_viewer.md +++ b/docs/developer_guides/viewer/local_viewer.md @@ -1,6 +1,6 @@ # (Legacy Viewer) Local Server -**Note:** this doc only applies to the legacy version of the viewer, which was the default in in Nerfstudio versions `<=0.3.4`. It was deprecated starting Nerfstudio version `1.0.0`, where it needs to be opted into via the `--vis viewer_legacy` argument. +**Note:** this doc only applies to the legacy version of the viewer, which was the default in Nerfstudio versions `<=0.3.4`. It was deprecated starting Nerfstudio version `1.0.0`, where it needs to be opted into via the `--vis viewer_legacy` argument. --- diff --git a/nerfstudio/data/utils/pixel_sampling_utils.py b/nerfstudio/data/utils/pixel_sampling_utils.py index ae77b3287f..717124f762 100644 --- a/nerfstudio/data/utils/pixel_sampling_utils.py +++ b/nerfstudio/data/utils/pixel_sampling_utils.py @@ -23,7 +23,7 @@ def dilate(tensor: Float[Tensor, "bs 1 H W"], kernel_size=3) -> Float[Tensor, "bs 1 H W"]: - """Dilate a tensor with 0s and 1s. 0s will be be expanded based on the kernel size. + """Dilate a tensor with 0s and 1s. 0s will be expanded based on the kernel size. Args: kernel_size: Size of the pooling region. Dilates/contracts 1 pixel if kernel_size is 3. diff --git a/nerfstudio/utils/tensor_dataclass.py b/nerfstudio/utils/tensor_dataclass.py index 293d978d7e..fb3331a355 100644 --- a/nerfstudio/utils/tensor_dataclass.py +++ b/nerfstudio/utils/tensor_dataclass.py @@ -280,7 +280,7 @@ def _apply_fn_to_fields( ) -> TensorDataclassT: """Applies a function to all fields of the tensor dataclass. - TODO: Someone needs to make a high level design choice for whether not not we want this + TODO: Someone needs to make a high level design choice for whether or not we want this to apply the function to any fields in arbitray superclasses. This is an edge case until we upgrade to python 3.10 and dataclasses can actually be subclassed with vanilla python and no janking, but if people try to jank some subclasses that are grandchildren of TensorDataclass