TASK: Deactivate ParallelWritingInWorkspacesTest test for now

we will implement a proper wait mechanism later.
Previously that test worked in the subscription branch as we used a FOR UPDATE lock which waits by default instead of using NOWAIT.

To not put the load on the database in `GET_LOCK` we call it with no wait (0 timeout)

Author: mhsdesign

Neos.ContentRepository.BehavioralTests/Tests/Parallel/ParallelWritingInWorkspaces/ParallelWritingInWorkspacesTest.php

@@ -38,10 +38,7 @@
 use PHPUnit\Framework\Assert;
 
 /**
- * This tests ensures that the subscribers are updated without any locking problems:
- *
- *     Exception in subscriber "contentGraph" while catching up:
- *     An exception occurred while executing a query: SQLSTATE[40001]: Serialization failure: 1213 Deadlock found when trying to get lock; try restarting transaction.
+ * This tests ensures that the subscribers are updated without any locking problems (and to test via {@see DebugEventProjection} that locking is used at all!)
  *
  * To test that we utilise two processes committing and catching up to a lot of events.
  * The is archived by creating nodes in a loop which have tethered nodes as this will lead to a lot of events being emitted in a fast way.
@@ -57,6 +54,9 @@ class ParallelWritingInWorkspacesTest extends AbstractParallelTestCase
 
     public function setUp(): void
     {
+        // todo assert that debug projection got events but no dubs!
+        $this->markTestSkipped('todo fix that processes WAIT instead of shoot each other!!! https://github.com/neos/neos-development-collection/pull/5376');
+
         parent::setUp();
         $this->log('------ process started ------');
 

Neos.ContentRepositoryRegistry/Classes/Factory/SubscriptionStore/DoctrineSubscriptionStore.php

@@ -14,6 +14,7 @@
 use Doctrine\DBAL\Types\Type;
 use Doctrine\DBAL\Types\Types;
 use Neos\ContentRepository\Core\Infrastructure\DbalSchemaDiff;
+use Neos\ContentRepository\Core\SharedModel\ContentRepository\ContentRepositoryId;
 use Neos\ContentRepository\Core\Subscription\Store\SubscriptionCriteria;
 use Neos\ContentRepository\Core\Subscription\Store\SubscriptionStoreInterface;
 use Neos\ContentRepository\Core\Subscription\Subscription;
@@ -31,7 +32,8 @@
 final class DoctrineSubscriptionStore implements SubscriptionStoreInterface
 {
     public function __construct(
-        private string $tableName,
+        private readonly ContentRepositoryId $contentRepositoryId,
+        private readonly string $tableName,
         private readonly Connection $dbal,
         private readonly ClockInterface $clock,
     ) {
@@ -167,17 +169,18 @@ private static function fromDatabase(array $row): Subscription
     public function acquireLock(): void
     {
         // todo fully implement https://github.com/patchlevel/event-sourcing/blob/caaf54fcf32c0e42b1036a5c7ff77c1a37af0105/src/Store/DoctrineDbalStore.php#L456
-        $result = $this->dbal->fetchOne(sprintf('SELECT GET_LOCK("%s", %d)', 'default', 0));
+        // todo check if 16 chars (crID) is a good lock value?
+        $result = $this->dbal->fetchOne(sprintf('SELECT GET_LOCK("%s", %d)', $this->contentRepositoryId->value, 0));
         if ($result !== 1) {
-            throw new \RuntimeException('failed to acquire lock');
+            throw new \RuntimeException('Failed to acquire lock for subscriptions.', 1733135506);
         }
     }
 
     public function releaseLock(): void
     {
-        $result = $this->dbal->fetchOne(sprintf('SELECT RELEASE_LOCK("%s")', 'default'));
+        $result = $this->dbal->fetchOne(sprintf('SELECT RELEASE_LOCK("%s")', $this->contentRepositoryId->value));
         if ($result !== 1) {
-            throw new \RuntimeException('failed to release lock');
+            throw new \RuntimeException('Failed to release lock for subscriptions.', 1733135506);
         }
     }
 

Neos.ContentRepositoryRegistry/Classes/Factory/SubscriptionStore/SubscriptionStoreFactory.php

@@ -22,6 +22,11 @@ public function __construct(
     /** @param array<string, mixed> $options */
     public function build(ContentRepositoryId $contentRepositoryId, ClockInterface $clock, array $options): SubscriptionStoreInterface
     {
-        return new DoctrineSubscriptionStore(sprintf('cr_%s_subscriptions', $contentRepositoryId->value), $this->connection, $clock);
+        return new DoctrineSubscriptionStore(
+            $contentRepositoryId,
+            sprintf('cr_%s_subscriptions', $contentRepositoryId->value),
+            $this->connection,
+            $clock
+        );
     }
 }