From 93007c045c2875ac58e803850a5966f7b7b86c0c Mon Sep 17 00:00:00 2001 From: Busra Demir Date: Fri, 20 Dec 2024 14:47:01 +0100 Subject: [PATCH 1/2] Update neon_fixtures.py - Security Incident this line is exposing the AWS credentials which was raised in a security incident. We need to remove this line to prevent more aws keys exposing in the public s3 buckets https://github.com/neondatabase/neon/blob/9c53b41245e3aecba30c2e05df4eeabe45fd39ac/.github/actions/allure-report-store/action.yml#L4 is the workflow that uploads reports to S3 -> using OIDC --- test_runner/fixtures/neon_fixtures.py | 1 - 1 file changed, 1 deletion(-) diff --git a/test_runner/fixtures/neon_fixtures.py b/test_runner/fixtures/neon_fixtures.py index 9f78ad120b91..aba7e795c619 100644 --- a/test_runner/fixtures/neon_fixtures.py +++ b/test_runner/fixtures/neon_fixtures.py @@ -4600,7 +4600,6 @@ def scrubber_cli( ] args = base_args + args - log.info(f"Invoking scrubber command {args} with env: {env}") (output_path, stdout, status_code) = subprocess_capture( self.log_dir, args, From 5905c71ec5ecd5374bcd23a2494b6b34031e8ead Mon Sep 17 00:00:00 2001 From: Busra Demir Date: Fri, 20 Dec 2024 14:53:05 +0100 Subject: [PATCH 2/2] Update neon_fixtures.py - keep args, delete env --- test_runner/fixtures/neon_fixtures.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test_runner/fixtures/neon_fixtures.py b/test_runner/fixtures/neon_fixtures.py index aba7e795c619..7826cb6b2f10 100644 --- a/test_runner/fixtures/neon_fixtures.py +++ b/test_runner/fixtures/neon_fixtures.py @@ -4600,6 +4600,8 @@ def scrubber_cli( ] args = base_args + args + log.info(f"Invoking scrubber command {args}") + (output_path, stdout, status_code) = subprocess_capture( self.log_dir, args,