Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging a block with NEEDS_NETHERITE_TOOL allows any tool to mine that block #1571

Open
jcotton42 opened this issue Sep 30, 2024 · 0 comments · May be fixed by #1572
Open

Tagging a block with NEEDS_NETHERITE_TOOL allows any tool to mine that block #1571

jcotton42 opened this issue Sep 30, 2024 · 0 comments · May be fixed by #1572
Assignees
Labels
1.21.1 Targeted at Minecraft 1.21.1

Comments

@jcotton42
Copy link

jcotton42 commented Sep 30, 2024

Minecraft Version: 1.21.1

NeoForge Version: 21.1.62

Logs: N/A

Steps to Reproduce:

  1. Add a block to a mod, with requiresCorrectToolForDrops
  2. Tag that block with Tags.Blocks.NEEDS_NETHERITE_TOOL and BlockTags.MINEABLE_WITH_PICKAXE (though any tool type tag should do for the latter)
  3. Open Minecraft
  4. Observe that any tier of pickaxe can mine the block, see screenshot

image

Description of issue:
Tagging a block with NEEDS_NETHERITE_TOOL does not actually force the use of Netherite to mine the block. This appears to be because none of the INCORRECT_FOR_x_TOOL tags include NEEDS_NETHERITE_TOOL.

In my own test environment, I was able to get the expected behavior (only Netherite can mine NEEDS_NETHERITE_TOOL blocks) by adding the following to my block tags provider:

tag(BlockTags.INCORRECT_FOR_WOODEN_TOOL).addTag(Tags.Blocks.NEEDS_NETHERITE_TOOL)
tag(BlockTags.INCORRECT_FOR_STONE_TOOL).addTag(Tags.Blocks.NEEDS_NETHERITE_TOOL)
tag(BlockTags.INCORRECT_FOR_IRON_TOOL).addTag(Tags.Blocks.NEEDS_NETHERITE_TOOL)
tag(BlockTags.INCORRECT_FOR_GOLD_TOOL).addTag(Tags.Blocks.NEEDS_NETHERITE_TOOL)
tag(BlockTags.INCORRECT_FOR_DIAMOND_TOOL).addTag(Tags.Blocks.NEEDS_NETHERITE_TOOL)

Though, this assumes that Neoforge wants to treat Netherite's mining ability as being superior to Diamond.

Edit: added screenshot
Edit 2: added incorrect for stone, oops

@jcotton42 jcotton42 added the triage Needs triaging and confirmation label Sep 30, 2024
@TelepathicGrunt TelepathicGrunt added 1.21.1 Targeted at Minecraft 1.21.1 and removed triage Needs triaging and confirmation labels Sep 30, 2024
@TelepathicGrunt TelepathicGrunt self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1
Projects
None yet
2 participants