Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deobfuscation is not applied to dependencies with a classifier #230

Open
Lapis256 opened this issue Jan 29, 2025 · 0 comments
Open

Deobfuscation is not applied to dependencies with a classifier #230

Lapis256 opened this issue Jan 29, 2025 · 0 comments

Comments

@Lapis256
Copy link

Dependencies added with a classifier do not get deobfuscated.
Normally, mods added via modRuntimeOnly are deobfuscated automatically, but this does not seem to apply when a classifier is included.

Versions:

  • Minecraft: 1.20.1
  • Forge: 47.1.3
  • ModDevGradle: 2.0.76

Steps to Reproduce:

Add the following dependency to MDK-Forge-1.20.1-ModDevGradle:

modRuntimeOnly("mekanism:Mekanism:1.20.1-10.4.14.71:generators")

Then, run the runClient task. The game fails to launch with the following error:

[00:57:41] [modloading-worker-0/ERROR] [ne.mi.fm.ja.FMLModContainer/LOADING]: Failed to create mod instance. ModID: mekanismgenerators, class mekanism.generators.common.MekanismGenerators
java.lang.NoSuchFieldError: f_156653_
	at mekanism.generators.common.config.GeneratorsConfig.<init>(GeneratorsConfig.java:151) ~[Mekanism-1.20.1-10.4.14.71-generators.jar%23197!/:10.4.14] {re:classloading}
	at mekanism.generators.common.config.MekanismGeneratorsConfig.<clinit>(MekanismGeneratorsConfig.java:12) ~[Mekanism-1.20.1-10.4.14.71-generators.jar%23197!/:10.4.14] {re:classloading}
	at mekanism.generators.common.MekanismGenerators.<clinit>(MekanismGenerators.java:52) ~[Mekanism-1.20.1-10.4.14.71-generators.jar%23197!/:10.4.14] {re:classloading}
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] {}
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] {}
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] {}
	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?] {}
	at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?] {}
	at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:68) ~[javafmllanguage-1.20.1-47.1.3.jar%23191!/:?] {}
	at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$10(ModContainer.java:123) ~[fmlcore-1.20.1-47.1.3.jar%23190!/:?] {}
	at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
	at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {}
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {}

Expected Behavior:

Dependencies with a classifier should be deobfuscated just like other mods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant